Refactors kandan.js; Turns the huge function into bits

Signed-off-by: Akash Manohar J <akash@akash.im>
kandanapp · Mar 28, 2012 · b8fd30e · b8fd30e
1 parent 19cd88b
commit b8fd30e
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 20 deletions.
diff --git a/app/assets/javascripts/backbone/kandan.js.coffee b/app/assets/javascripts/backbone/kandan.js.coffee
@@ -18,7 +18,7 @@ window.Kandan =
 
   # TODO this is a helper method to register plugins
   # in the order required until we come up with plugin management
-  register_plugins: ->
+  registerPlugins: ->
     plugins = [
       "UserList"
       ,"YouTubeEmbed"
@@ -34,7 +34,7 @@ window.Kandan =
 
   initBroadcasterAndSubscribe: ()->
     window.broadcaster = new Kandan.Broadcasters.FayeBroadcaster()
-    window.broadcaster.subscribe "/channels/*" ##{channel.get('id')}
+    window.broadcaster.subscribe "/channels/*"
 
 
   initChatbox: ()->
@@ -65,25 +65,25 @@ window.Kandan =
     $(document).bind 'changeData', (element, name, value)->
       Kandan.Data.ActiveUsers.runCallbacks('change') if name=="active_users"
 
+  onFetchActiveUsers: (channels)=>
+    return (activeUsers)=>
+      if not Kandan.Helpers.ActiveUsers.collectionHasCurrentUser(activeUsers)
+        activeUsers.add([Kandan.Helpers.Users.currentUser()])
+
+      Kandan.Helpers.ActiveUsers.setFromCollection(activeUsers)
+      Kandan.registerPlugins()
+      Kandan.Plugins.initAll()
+      Kandan.initChatArea(channels)
+      Kandan.initChatbox()
+      Kandan.initTabs()
+      Kandan.Widgets.initAll()
+
+
   init: ->
     channels = new Kandan.Collections.Channels()
     channels.fetch({success: (channelsCollection)=>
       @initBroadcasterAndSubscribe()
       @bindEventCallbacks()
-
-      active_users = new Kandan.Collections.ActiveUsers()
-      active_users.fetch({
-        success: (activeUsersCollection)=>
-
-          if not Kandan.Helpers.ActiveUsers.collectionHasCurrentUser(activeUsersCollection)
-            activeUsersCollection.add([Kandan.Helpers.Users.currentUser()])
-
-          Kandan.Helpers.ActiveUsers.setFromCollection(activeUsersCollection)
-          Kandan.register_plugins()
-          Kandan.Plugins.init_all()
-          @initChatArea(channelsCollection)
-          @initChatbox()
-          @initTabs()
-          Kandan.Widgets.init_all()
-      })
+      activeUsers = new Kandan.Collections.ActiveUsers()
+      activeUsers.fetch({success: @onFetchActiveUsers(channelsCollection)})
     })
diff --git a/app/assets/javascripts/backbone/plugins.js.coffee b/app/assets/javascripts/backbone/plugins.js.coffee
@@ -7,5 +7,5 @@ class Kandan.Plugins
   @all: ()->
     @plugins
 
-  @init_all: ()->
+  @initAll: ()->
     eval(plugin).init() for plugin in @all()
diff --git a/app/assets/javascripts/backbone/widgets.js.coffee b/app/assets/javascripts/backbone/widgets.js.coffee
@@ -7,7 +7,7 @@ class Kandan.Widgets
   @all: ()->
     @widgets
 
-  @init_all: ()->
+  @initAll: ()->
     $.each @widgets, (widget_namespace, el_name)=>
       @init(widget_namespace)