Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the Instructions box text and Readme.md screenshot #146

Merged
merged 2 commits into from
Oct 29, 2023

Conversation

SoumyadevSaha
Copy link
Contributor

Fixes Issue🛠️

Closes #139

Description👨‍💻

Applied changes:

  1. Updated the instrusctions box: Notified the players about the new feature; the bombs and lives in the game.
  2. Updated the instruction box screen-shot in readme.md: The new updated instruction box's screenshot has been pasted in the readme.md

Type of change📄

  • New feature (non-breaking change which adds functionality)

How this has been tested✅

Tested in the local machine, the changes are being reflected and displayed successfully.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

Screenshot 2023-10-29 at 5 57 35 PM

@netlify
Copy link

netlify bot commented Oct 29, 2023

Deploy Preview for click-the-edible-game ready!

Name Link
🔨 Latest commit 157c41d
🔍 Latest deploy log https://app.netlify.com/sites/click-the-edible-game/deploys/653e57490e7002000805e0ed
😎 Deploy Preview https://deploy-preview-146--click-the-edible-game.netlify.app/assets/main
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoumyadevSaha SoumyadevSaha reopened this Oct 29, 2023
@Rakesh9100 Rakesh9100 changed the title documentation: updated the instrusctions box text and also its ss in readme.md Updated the Instructions box text and Readme.md screenshot Oct 29, 2023
@Rakesh9100
Copy link
Owner

What is the update in the main.js file? @SoumyadevSaha

@SoumyadevSaha
Copy link
Contributor Author

SoumyadevSaha commented Oct 29, 2023

What is the update in the main.js file? @SoumyadevSaha

There, in the closeInstruction() function, I saw that in all cases, the isRunning variable was made to be 1. but that shouldn't be the case, otherwise, it will interfare with the bgm playing. It should not be triggered when isRunning is -1. I only fixed that bug.

@Rakesh9100
Copy link
Owner

Okay, Merged!! 🥳 @SoumyadevSaha

@Rakesh9100 Rakesh9100 merged commit 8c21dce into Rakesh9100:main Oct 29, 2023
4 checks passed
@Rakesh9100
Copy link
Owner

give @SoumyadevSaha 25 points

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion slop3.0 SLoP 3.0 Open Source Program labels Oct 29, 2023
@SoumyadevSaha SoumyadevSaha deleted the uiuxdocs_update branch October 29, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion slop3.0 SLoP 3.0 Open Source Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Instruction box in the game
2 participants