Check commit_with_diff() inside generate_new_block_and_state()

[mikiw]

No description provided.

[FabijanC]

Transferring from #484:

Refactoring will probably have to deal with this problem of redundant state committing:

In handle_accepted_transaction, we call commit_with_diff and optionally generate_new_block_and_state:

starknet-devnet-rs/crates/starknet-devnet-core/src/starknet/mod.rs

Lines 457 to 480 in 3ad8145

	pub(crate) fn handle_accepted_transaction(
	&mut self,
	transaction_hash: &TransactionHash,
	transaction: &TransactionWithHash,
	tx_info: TransactionExecutionInfo,
	) -> DevnetResult<()> {
	let state_diff = self.commit_with_diff()?;
	let trace = create_trace(
	&mut self.pending_state.state,
	transaction.get_type(),
	&tx_info,
	state_diff.clone().into(),
	)?;
	let transaction_to_add = StarknetTransaction::create_accepted(transaction, tx_info, trace);
	// add accepted transaction to pending block
	self.blocks.pending_block.add_transaction(*transaction_hash);
	self.transactions.insert(transaction_hash, transaction_to_add);
	// create new block from pending one, only if block on-demand mode is disabled
	if !self.config.blocks_on_demand {
	self.generate_new_block_and_state(state_diff)?;

In generate_new_block_and_state we call commit_with_diff again:

starknet-devnet-rs/crates/starknet-devnet-core/src/starknet/mod.rs

Line 335 in 3ad8145

self.commit_with_diff()?;