Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eleventy peer dependency #28

Closed
paulrobertlloyd opened this issue Oct 6, 2021 · 4 comments
Closed

Update eleventy peer dependency #28

paulrobertlloyd opened this issue Oct 6, 2021 · 4 comments
Assignees
@zachleat
Labels
bug Something isn't working
Milestone
v1.1.2

Comments

@paulrobertlloyd
Copy link

11ty is at v1.0.0-beta, but this module requires >=0.11.0. Have to force install to get past this issue. The plugin works with v1.0.0 as far as I can tell.
@zachleat zachleat self-assigned this Oct 7, 2021
@zachleat zachleat added the bug Something isn't working label Oct 7, 2021
@zachleat zachleat mentioned this issue Oct 7, 2021
Closed
@zachleat
Copy link
Member

zachleat commented Oct 7, 2021

Going to solve this in core at 11ty/eleventy#2001

@zachleat
Copy link
Member

zachleat commented Oct 7, 2021

Woops, this plugin isn’t using the 11ty compatibility check we have in place for the others. I’ll get it updated.

@zachleat
Copy link
Member

zachleat commented Oct 7, 2021

As an example, the standard version checking approach: https://github.com/11ty/eleventy-navigation/blob/fccb334e0d7cad363bda691178cb53e35ee79981/package.json#L35 and https://github.com/11ty/eleventy-navigation/blob/fccb334e0d7cad363bda691178cb53e35ee79981/.eleventy.js#L6

@zachleat zachleat added this to the v1.1.2 milestone Oct 7, 2021
@zachleat
Copy link
Member

zachleat commented Oct 7, 2021

Oops, I didn’t link this one up but this is now solved with d18b45a

Shipped with version 1.1.2

@zachleat zachleat closed this as completed Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zachleat zachleat

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.1.2
Development

No branches or pull requests
2 participants
@zachleat @paulrobertlloyd