Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't offer to save GitHub Secret format #91

Closed
jodyheavener opened this issue Oct 13, 2022 · 1 comment · Fixed by #175
Closed

Don't offer to save GitHub Secret format #91

jodyheavener opened this issue Oct 13, 2022 · 1 comment · Fixed by #175
Labels
enhancement New feature or request

Comments

@jodyheavener
Copy link
Member

Your environment

op-vscode version: v1.0.2

Steps to reproduce

Create a GitHub Workflow YML file that references a GitHub secret but has a Save trigger keyword, e.g.:

CleanShot 2022-10-13 at 09 15 29@2x

What happened?

A "Save in 1Password" prompt is appearing.

The words "API_KEY" are triggering the prompt.

What did you expect to happen?

No Save prompt. The secret is already stored in GitHub secrets.

The user could be using 1Password to store their secrets for Actions, but in some cases they will need to use GitHub secrets, and when this is necessary we should respect that by not suggesting to store in 1Password.

We should check if the value matches the regexp /\${{ secrets\.(?:.+) }}/

@jodyheavener jodyheavener added bug Something isn't working verified This issue has been verified on our end labels Oct 13, 2022
@jodyheavener jodyheavener added enhancement New feature or request and removed bug Something isn't working verified This issue has been verified on our end labels Sep 20, 2023
@jodyheavener
Copy link
Member Author

It might be worth trying to ignore any instance of ${{ ... }} since, for example, ${{ steps.foo.outputs.TOKEN }} should be ignored as well.

@jodyheavener jodyheavener added the hacktoberfest This issue is open to submissions from Hacktoberfest participants label Oct 3, 2023
@jodyheavener jodyheavener removed the hacktoberfest This issue is open to submissions from Hacktoberfest participants label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant