You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Create a GitHub Workflow YML file that references a GitHub secret but has a Save trigger keyword, e.g.:
What happened?
A "Save in 1Password" prompt is appearing.
The words "API_KEY" are triggering the prompt.
What did you expect to happen?
No Save prompt. The secret is already stored in GitHub secrets.
The user could be using 1Password to store their secrets for Actions, but in some cases they will need to use GitHub secrets, and when this is necessary we should respect that by not suggesting to store in 1Password.
We should check if the value matches the regexp /\${{ secrets\.(?:.+) }}/
The text was updated successfully, but these errors were encountered:
Your environment
op-vscode version: v1.0.2
Steps to reproduce
Create a GitHub Workflow YML file that references a GitHub secret but has a Save trigger keyword, e.g.:
What happened?
A "Save in 1Password" prompt is appearing.
The words "API_KEY" are triggering the prompt.
What did you expect to happen?
No Save prompt. The secret is already stored in GitHub secrets.
The user could be using 1Password to store their secrets for Actions, but in some cases they will need to use GitHub secrets, and when this is necessary we should respect that by not suggesting to store in 1Password.
We should check if the value matches the regexp
/\${{ secrets\.(?:.+) }}/
The text was updated successfully, but these errors were encountered: