Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a panel with project misconfigurations & optimisation suggestions #389

Open
6 of 11 tasks
mdouchin opened this issue Dec 3, 2021 · 10 comments
Open
6 of 11 tasks
Assignees

Comments

@mdouchin
Copy link
Contributor

mdouchin commented Dec 3, 2021

We have a list of long well-known possible misconfigurations in a Lizmap project:

  • PostgreSQL layers without a password (or better a service file)
  • No integer primary keys
  • int8 primary keys 39a6798
  • Layer not published as WFS -> do it for the user
  • Identifier field not published as WFS
  • Local datasource (C:/ , etc.)
  • ...

Or pieces of advice to improve performances or "user-friendlyship"

  • Check the "Add the geometry to WMS GetFeatureInfo response"
  • Use the "Trust" project option
  • Use JPEG format for the base layers and for the layers with no need for transparency
  • Use png; mode=16bit or png; mode=8bit when there is few colors in style
  • Check Use estimated table metadata when creating connexion
  • ...

It could be great to list these things and warn the user with a of changes to make.

@mdouchin
Copy link
Contributor Author

mdouchin commented Dec 3, 2021

cc @rldhont @nboisteault

@nboisteault nboisteault changed the title Add a panel with project musconfigurations & optimisation suggestions Add a panel with project misconfigurations & optimisation suggestions Dec 6, 2021
@Gustry
Copy link
Member

Gustry commented Jun 17, 2022

  • According to the discussion today for LWC 3.6 : check the layer ID for as name
  • Check fields used in all table manager if they are still in WMS/WFS
  • Do not use bigint primary key : 39a6798
  • geometry not included on the server side, while some expressions are using it, easiest is display name
  • Any layer with a "qgis auth manager" set up (already done for vectors), IGN raster with basic auth
  • A layer is not "queryable" in the project properties, "datasource tab" while the popup is enabled

@Gustry
Copy link
Member

Gustry commented Jul 13, 2023

List of current QMessageBox used, because of a project check :

  • Address search without a key : IGN&google. By the way, this really something to fix after bbd67e1
  • "Use layer IDs as name" since LWC 3.6, blocking the saving
  • SAAS
    • ECW
    • Auth DB for postgresql
    • Path higher than ../../
  • Invalid field type tid, int8 ...
  • Duplicated layer with filters
  • Legend image 3.6
  • Deprecated lizmap popup for all versions
  • Legacy server without admin user, LWC 3.5 etc
  • Legacy server not providing a correct metadata, the plugin on the server side was not required before 3.6
  • Accent, space ... in project name (this has been fixed in latest LWC releases, need to check)
  • Capitalize layer names
  • Absolute path in project properties

@Gustry
Copy link
Member

Gustry commented Feb 26, 2024

  • In Add French GEOPF check #564 we were thinking to check rasters having a authcfg as well. It has been done only for French IGN provider for now to have an explicit error message. We can extend with generic layers as well.

@nboisteault
Copy link
Member

  • warn users when using jp2 files and propose a conversion to tiled GeoTiff, compressed to jpeg with pyramids
  • warn users about heavy jpg, png, svg files in print composer

@nboisteault
Copy link
Member

  • suggest server cache for not editable layers and no specific rights. We could save a lot of GetMap requests.

@Gustry
Copy link
Member

Gustry commented Apr 2, 2024

@nboisteault We are trying to make the list objective :)

warn users about heavy jpg, png, svg files in print composer

What is heavy ? :)

suggest server cache for not editable layers and no specific rights

This is IMHO very project specific. For now, we can't make "suggestion", as all "errors" are reported in the CFG file and then displayed in LWC when connected as an admin, so we must stay objective.

@Gustry
Copy link
Member

Gustry commented Apr 2, 2024

suggest server cache for not editable layers and no specific rights. We could save a lot of GetMap requests.

See the issue 3liz/lizmap-web-client#4327 The cache can lead to other side effect and not necessary for all layers.

@nboisteault
Copy link
Member

@nboisteault We are trying to make the list objective :)

warn users about heavy jpg, png, svg files in print composer

What is heavy ? :)

I don't know ;)

suggest server cache for not editable layers and no specific rights

This is IMHO very project specific. For now, we can't make "suggestion", as all "errors" are reported in the CFG file and then displayed in LWC when connected as an admin, so we must stay objective.

So let's not write it in cfg :)

@nboisteault
Copy link
Member

suggest server cache for not editable layers and no specific rights. We could save a lot of GetMap requests.

See the issue 3liz/lizmap-web-client#4327 The cache can lead to other side effect and not necessary for all layers.

I'll fix this one.

@mdouchin mdouchin unpinned this issue Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants