Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not so much an issue. More a question: slick.grid.js updateColumnProps - if (!m.resizable).. #559

Closed
JGFMK opened this issue Nov 30, 2020 · 3 comments

Comments

@JGFMK
Copy link

JGFMK commented Nov 30, 2020

if (!m.resizable) {
// there is difference between user resizable and autoWidth resizable
//m.autoSize.autosizeMode = Slick.ColAutosizeMode.Locked;
}

Is there some unfinished business here? If with commented out code...

@JGFMK JGFMK changed the title Not so much an issue. More a question: slick.grid.js updateColumnProps - if !(m.resizable).. Not so much an issue. More a question: slick.grid.js updateColumnProps - if (!m.resizable).. Nov 30, 2020
@ghiscoding
Copy link
Collaborator

ghiscoding commented Nov 30, 2020

seems like @6pac when he introduced the column auto-width resized by text content

image

@6pac
Copy link
Owner

6pac commented Nov 30, 2020

I think this can be removed, it's a feature that is still needing a bit of tweaking, so I think I left it in as a memory jogger. Looks like I had it initially assuming that !m.resizable meant the user wanted a fixed width column, but then realised that it concerns whether the column is user-resizible. So they may want it to be non-user-resizable, but still to have an initial autosize based on the text width.

The autosizing framework does need a bit of developer tweaking of the column autosize options in certain column cases to get good results, so it doesn't always work well in the default 'ContentIntelligent' mode. However, if you don't like it, you can always go back to the old way by using Legacy mode (hint - that does an even worse job!).

It's not till you try to build it that you realise that autosizing well is pretty hard to automate.

@ghiscoding
Copy link
Collaborator

that code was removed in the upcoming v4.0 - Roadmap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants