Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong coordinates in juelich-tower-measurements.json #34

Open
MarleneBusch opened this issue Sep 24, 2024 · 1 comment · May be fixed by #31
Open

Wrong coordinates in juelich-tower-measurements.json #34

MarleneBusch opened this issue Sep 24, 2024 · 1 comment · May be fixed by #31
Assignees
Labels
bug Something isn't working

Comments

@MarleneBusch
Copy link
Collaborator

Wrong coordinates in juelich-tower-measurements.json
A clear and concise description of what the bug is.

To reproduce
Steps to reproduce the behavior:

  1. Open juelich-tower-measurements.json,
  2. Go to coordinates
  3. Transform coordinates to offsets in m with utils.calculate_heliostat_position_in_m_from_lat_lon

Expected behavior
The solar_tower_juelich_upper center coordinate should be something like [0, 0, 50] but deviates greatly.

Additional context
The utils functions to transform the coordinates were tested and seem to be right.

@MarleneBusch MarleneBusch added the bug Something isn't working label Sep 24, 2024
@Filos1992
Copy link
Member

@kalebphipps I looked into the problem and noticed the following:

We have two functions: calculate_heliostat_position_in_m_from_lat_lon (converts lat/lon to meters) and its reverse (converts meters back to lat/lon). When calculating both directions from the coordinates [50, 50, 50], the results differ slightly, resulting in [49.98, 49.98, 50]. I plan to investigate this further at a later stage.

However, what I don't quite understand is why, when using the lat/lon -> m direction with values such as solar_tower_upper_center, the resulting values differ significantly from those initially provided in the CSV document. Could you provide some insight into this?

@kalebphipps kalebphipps linked a pull request Oct 2, 2024 that will close this issue
9 tasks
@kalebphipps kalebphipps linked a pull request Oct 2, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants