Pr 4 #4
Pr 4 #4
Conversation
| require 'minitest/reporters' | ||
| require 'minitest/skip_dsl' | ||
| require 'awesome_print' | ||
| # Add simplecov |
|
|
||
| describe "find_xml_file" do | ||
| it "should return nil if there are no xml files" do | ||
| expect(find_xml_file('.')).must_be_nil |
| if filename.match "\.xml$" | ||
| xml_file = filename | ||
| break | ||
| end |
There was a problem hiding this comment.
This will iterate through "files", break and return the first match and not all matches, is that your intention?
| @@ -0,0 +1,15 @@ | |||
|
|
|||
| def find_xml_file(folder) | |||
| files = Dir.entries(folder) | |||
There was a problem hiding this comment.
please include to describe what this does
| files.each do |filename| | ||
| if filename.match "\.xml$" | ||
| xml_file = filename | ||
| break |
| @@ -0,0 +1,15 @@ | |||
|
|
|||
| def find_xml_file(folder) | |||
| files = Dir.entries(folder) | |||
There was a problem hiding this comment.
What is Dir? Please add comment to explain where this comes from
| end | ||
| end | ||
|
|
||
| return xml_file |
There was a problem hiding this comment.
what is xml_file is still nil (i.e., no match) - do you want to return an informative statement in this case?
|
|
||
| files.each do |filename| | ||
| if filename.match "\.xml$" | ||
| xml_file = filename |
There was a problem hiding this comment.
Are you only looking for the last xml file? This will replace the xml file each time it finds one
| @@ -0,0 +1,15 @@ | |||
|
|
|||
There was a problem hiding this comment.
Consider adding a comment to describe the purpose of this function
| expect(find_xml_file('.')).must_be_nil | ||
| end | ||
|
|
||
| it "should return an xml file if it's in the folder" do |
There was a problem hiding this comment.
Is "example.xml" the only xml file in your test data folder? Consider clarifying which xml file you are expecting it to find
| require 'minitest/reporters' | ||
| require 'minitest/skip_dsl' | ||
| require 'awesome_print' | ||
| # Add simplecov |
There was a problem hiding this comment.
simplecov doesn't look like it was added
This method finds the 1st xml file in the folder.