-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr 4 #4
base: master
Are you sure you want to change the base?
Pr 4 #4
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
require 'rake/testtask' | ||
|
||
Rake::TestTask.new do |t| | ||
t.libs = ["lib"] | ||
t.warning = true | ||
t.test_files = FileList['test/*_test.rb'] | ||
end | ||
|
||
task default: :test | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
|
||
def find_xml_file(folder) | ||
files = Dir.entries(folder) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is Dir? Please add comment to explain where this comes from There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please include to describe what this does |
||
|
||
xml_file = nil | ||
|
||
files.each do |filename| | ||
if filename.match "\.xml$" | ||
xml_file = filename | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are you only looking for the last xml file? This will replace the xml file each time it finds one |
||
break | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. use return instead of break |
||
end | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will iterate through "files", break and return the first match and not all matches, is that your intention? |
||
end | ||
|
||
return xml_file | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what is xml_file is still nil (i.e., no match) - do you want to return an informative statement in this case? |
||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
require_relative 'test_helper' | ||
|
||
describe "find_xml_file" do | ||
it "should return nil if there are no xml files" do | ||
expect(find_xml_file('.')).must_be_nil | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks good |
||
end | ||
|
||
it "should return an xml file if it's in the folder" do | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is "example.xml" the only xml file in your test data folder? Consider clarifying which xml file you are expecting it to find |
||
expect(find_xml_file('./test/test_data')).must_equal "example.xml" | ||
end | ||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
require 'minitest' | ||
require 'minitest/autorun' | ||
require 'minitest/reporters' | ||
require 'minitest/skip_dsl' | ||
require 'awesome_print' | ||
# Add simplecov | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. include simplecov! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. simplecov doesn't look like it was added |
||
|
||
Minitest::Reporters.use! Minitest::Reporters::SpecReporter.new | ||
|
||
# Require_relative your lib files here! | ||
|
||
require_relative '../find_xml_file.rb' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a comment to describe the purpose of this function