Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSTS in AdGuard Home (Strict-Transport-Security) and Http3.0? #1768

Closed
Potterli20 opened this issue Jun 4, 2020 · 17 comments
Closed

HSTS in AdGuard Home (Strict-Transport-Security) and Http3.0? #1768

Potterli20 opened this issue Jun 4, 2020 · 17 comments

Comments

@Potterli20
Copy link

Adguardhome requires adding HSTS and forcing Https.

@Potterli20
Copy link
Author

HTTP_Strict_Transport_Security:
https://en.m.wikipedia.org/wiki/HTTP_Strict_Transport_Security

@ameshkov ameshkov changed the title Adguardhome :forcing Https HSTS in AdGuard Home (Strict-Transport-Security) Jun 4, 2020
@ameshkov
Copy link
Member

ameshkov commented Jun 4, 2020

This may be an option, let's see how many upvotes this feature request get.

For now the solution would be to configure a reverse proxy (nginx, caddy, or anything else) and configure it to add this header to all responses.

@Potterli20
Copy link
Author

This may be an option, let's see how many upvotes this feature request get.

For now the solution would be to configure a reverse proxy (nginx, caddy, or anything else) and configure it to add this header to all responses.

But I don't want to use an anti-agent, I just want to add it to the original Settings, so I don't need an anti-agent.

@Kagura-Nanaa
Copy link

我觉得这个功能很有用👍🏻

@Kagura-Nanaa
Copy link

我觉得这个功能很有用👍🏻

I find it useful

@Potterli20
Copy link
Author

我觉得这个功能很有用👍🏻

对哈😂

@banbendalao
Copy link

这可能是一个选项,让我们看看此功能请求获得了多少支持。

目前,解决方案是配置反向代理(nginx,caddy或其他任何方式),并将其配置为将此标头添加到所有响应中。

doh client will not try to use http, I think this function is useless

This may be an option, let's see how many upvotes this feature request get.

For now the solution would be to configure a reverse proxy (nginx, caddy, or anything else) and configure it to add this header to all responses.

doh client will not try to use http, I think this function is useless

@ameshkov
Copy link
Member

ameshkov commented Jun 8, 2020

Guys, Das @banbendalao has pointed out, if you need it for DOH - it is useless.

The only reason for adding it is to make sure that you access the admin interface over HTTPS.

@Potterli20
Copy link
Author

Guys, Das @banbendalao has pointed out, if you need it for DOH - it is useless.

The only reason for adding it is to make sure that you access the admin interface over HTTPS.

If I think this function is not necessary, but I feel that the security transfer is necessary. The current product is the product of secure and private DNS AdGuardHome.

@ameshkov
Copy link
Member

ameshkov commented Jun 8, 2020

Why closing it? There're many upvotes already

@ameshkov ameshkov reopened this Jun 8, 2020
@Potterli20
Copy link
Author

Why closing it? There're many upvotes already

If it doesn't make sense, don't add it. This feature leads me to the question of security.

@Potterli20
Copy link
Author

Although the DOH client will not attempt to use HTTP, I feel that this is a secure feature.

@ameshkov
Copy link
Member

Well, okay then. Reopen if you feel that it needs to be done and we'll see how it goes.

@Potterli20
Copy link
Author

@ameshkov Have you considered HTTP 3.0 protocol??

@Potterli20 Potterli20 changed the title HSTS in AdGuard Home (Strict-Transport-Security) HSTS in AdGuard Home (Strict-Transport-Security) and Http3.0? Jun 11, 2020
@ameshkov
Copy link
Member

@Potterli20 HTTP 3.0 will be supported eventually when it will be added to Go stdlib: golang/go#32204

But to be honest, I am skeptical about DNS-over-HTTPS in general. DNS-over-QuicTransport is a much better concept https://datatracker.ietf.org/doc/draft-ietf-dprive-dnsoquic/

@Potterli20
Copy link
Author

@Potterli20 HTTP 3.0 will be supported eventually when it will be added to Go stdlib: golang/go#32204

But to be honest, I am skeptical about DNS-over-HTTPS in general. DNS-over-QuicTransport is a much better concept https://datatracker.ietf.org/doc/draft-ietf-dprive-dnsoquic/

Ok, that means I like that feature

@Potterli20
Copy link
Author

#2049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants