Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the "Nothing to export" snack when trying to export rules with empty list of User rules #5176

Closed
Versty opened this issue Jan 17, 2024 · 0 comments

Comments

@Versty
Copy link
Contributor

Versty commented Jan 17, 2024

Issue Details

Currently the context menu option "Export" on the User rules screen (Protection -> Ad blocking -> User rules) can be used as usual even if the list of rules is empty, resulting in the creation of an empty file in the device storage.

Proposed solution

Show the "Nothing to export" snack instead of opening the file system to save an empty file.

Alternative solution

Does not display the "Export" option in the context menu if the list of user rules is empty.

Additional info

The same issue is applicable to User rules from DNS Protection module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants