-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] iOS: deprecate "requestAuthorization" method in favor of "react-native-permissions" #224
Comments
I personally agree with this. RNPermissions is an amazing library. Dropping requestAuthorization will allow us to focus solely on Geolocation. |
Right now I think we can print a warning for devs who uses |
adding to the above, app store will also reject your app if you add the always in use flag and not actually use it in your app's code, which is what happened in our case. This creates a loop you can not break out of. |
Just wondering: has anyone tackled this yet? |
This'll probably be removed in the next major release. Unfortunately I'm quite busy right now with my job, so the major version release will be a bit delayed I think. |
Do you have any update on this? |
Problem
requestAuthorization
method handles bothwhenInUse
&always
permission request. Since both logic resides in the code, you have to include bothNSLocationWhenInUseUsageDescription
&NSLocationAlwaysAndWhenInUseUsageDescription
ininfo.plist
file, even if you want to use onlywhenInUse
permission. Otherwise app store will reject your app submission, you can find the specific error here iOS App Store Build Missing Purpose String #198Benefits of using
react-native-permissions
whenInUse
&always
permission logic separately, you've to include the one you want in your Podfile.Relevant issues
#185
#198
#214
These features can be implemented in this library, but it feels like reinventing the wheels when there's already a good solution available. Let me know what you think.
The text was updated successfully, but these errors were encountered: