Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review endowments #10104

Open
mhofman opened this issue Sep 18, 2024 · 0 comments
Open

review endowments #10104

mhofman opened this issue Sep 18, 2024 · 0 comments
Assignees
Labels
asyncFlow related to membrane-based replay and upgrade of async functions enhancement New feature or request

Comments

@mhofman
Copy link
Member

mhofman commented Sep 18, 2024

What is the Problem Being Solved?

Endowments (#9304) merged without a thorough review (#9566), and seem to have bugs (e.g. #9830)

Description of the Design

Full review of #9933

In particular, one question that came up: why do endowments need to create durable unwrappers? This would result in a leak of state unwrapper instances every time the contract is restarted. See makeStateUnwrapper.

Or is there any check that all previously replaced endowments are replaced in the same way? With clear errors if not.

Security Considerations

Correctness

Scaling Considerations

No leak or growth per incarnation

Test Plan

See #9933

Upgrade Considerations

It must work

@mhofman mhofman added enhancement New feature or request asyncFlow related to membrane-based replay and upgrade of async functions labels Sep 18, 2024
@mhofman mhofman self-assigned this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asyncFlow related to membrane-based replay and upgrade of async functions enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant