Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log for actions against validators or delegators that are not active. #3317

Open
kyle-u410 opened this issue Jun 14, 2024 · 2 comments
Labels
bug Incorrect or unexpected behavior

Comments

@kyle-u410
Copy link

🐛 Bug Report

Currently any validator that is not active will have errors logged by all clients in the network for any delegation against that validator. This should not even be a DEBUG log I suspect. Maybe TRACE level.

Example log:

ERROR snarkvm_synthesizer::vm::helpers::rewards: Validator aleo1ca09uscr33gahs7r265lfcnqrr7hcwm0r5d5w98r4xjqr8m3avpqgyg3xh is not in the committee - skipping aleo1q9hx0rrry50060uzqw6g26rrnuv3g9h28ru5xe8hey9vv5z4p5zsf7ls2d

Steps to Reproduce

Delegate to unbonded validator.

Expected Behavior

No logs.

Your Environment

canary-0.2.1

@kyle-u410 kyle-u410 added the bug Incorrect or unexpected behavior label Jun 14, 2024
@zosorock
Copy link
Contributor

Thank you, @kyle-u410. I have concerns that, even without logging, this is an attack vector, because it will cause load in all clients and validators.

@kyle-u410
Copy link
Author

That concern is mitigated somewhat by the minimum delegation amount. We should make sure there is minimal time spent on this case, in the same way the positive rewards adjustment case is made fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect or unexpected behavior
Projects
None yet
Development

No branches or pull requests

2 participants