Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Improvement: don't pull in all features when adding snarkVM dependency #3344

Open
HarukaMa opened this issue Jul 3, 2024 · 0 comments
Labels
feature New feature or request

Comments

@HarukaMa
Copy link
Contributor

HarukaMa commented Jul 3, 2024

🚀 Feature

I think this is good to have: currently all snarkVM dependency declaration in snarkOS are using default features, which includes default feature rocksdb. Unfortunately, rocksdb itself is rather slow to build, and unless the library user is trying to run a full-fledged ledger, it would be an unnecessary component.

For example, I was trying to only link to snarkos-node-router-messages to have the message types for a P2P node implementation, but doing that would pull in rocksdb which I won't ever need.

This should be a really low priority one and probably can be done after mainnet launch.

Motivation

Better dev experience for users who use part of snarkOS as library.

Implementation

Cargo.toml changes to disable default features if a sub-component doesn't really rely on them.

Are you willing to open a pull request? (See CONTRIBUTING)

@HarukaMa HarukaMa added the feature New feature or request label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant