Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alevin-fry images to 0.4.1 (and maybe salmon?) #118

Closed
jashapiro opened this issue Jul 22, 2021 · 0 comments · Fixed by #119
Closed

Update alevin-fry images to 0.4.1 (and maybe salmon?) #118

jashapiro opened this issue Jul 22, 2021 · 0 comments · Fixed by #119
Assignees

Comments

@jashapiro
Copy link
Member

jashapiro commented Jul 22, 2021

In response to some comments from us COMBINE-lab/alevin-fry#22 (comment) alevin-fry now has better .json output files, so we should update. When we do that, some of the output files will change, but for the better! However, this will temporarily break scpcaTools (filing that issue separately).

We may want to wait for a coming version bump for salmon that will come in parallel, which adds back the cmd_info.json file for --rad outputs.

One other note along with that is that we can remove the t2g file (--tgMap) from the salmon alevin call, as this is no longer needed with --rad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant