Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing occurrences of aes_string() #212

Open
sjspielman opened this issue Apr 4, 2023 · 1 comment
Open

Consider removing occurrences of aes_string() #212

sjspielman opened this issue Apr 4, 2023 · 1 comment

Comments

@sjspielman
Copy link
Member

Currently, many of our plotting functions use aes_string() to handle data mappings. This function has been deprecated in newer ggplot2 versions, so we may want to think about moving away from this strategy and instead using aes() with so-called "curly-curly"'s{{}}.
Although I am opening this issue in this repo, this code change might/is(?) something we should do elsewhere (scpca-nf?), since this repo is more internal. But, I didn't want to forget this so filing here now!

@jashapiro
Copy link
Member

We do not currently have any instances of aes_string() in scpca-nf or scpcaTools, so it would just be here for now. But something to keep in mind as we translate any functions from here over to those locations.

Also, given experience with previous soft deprecation in the tidyverse, I do not expect aes_string() to go away for a very long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants