You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The unavailable_samples_count attribute represents all samples that do not have data files associated with them, but are included a project's sample_metadata.csv file. We update the Project::unavailable_samples_count in Project::update_downloadable_sample_count, which is called in loader::generate_computed_files after the completion of computed file generation.
Problem or idea
The way that we currently couple the setting of unavailable_samples_count alongside downloadable_sample_count is not necessarily the optimal approach, as we already know whether or not a sample is unavailable when its loaded into the database and don't need to wait until after computed file generation. Instead, we should set it in Project::update_project_aggregate_properties with other aggregate attributes.
The text was updated successfully, but these errors were encountered:
avrohomgottlieb
changed the title
Clarify setting of Project unavailable_samples_count attribute
Clarify setting of Project::unavailable_samples_count attribute
Sep 6, 2024
Context
The
unavailable_samples_count
attribute represents all samples that do not have data files associated with them, but are included a project'ssample_metadata.csv
file. We update theProject::unavailable_samples_count
inProject::update_downloadable_sample_count
, which is called inloader::generate_computed_files
after the completion of computed file generation.Problem or idea
The way that we currently couple the setting of
unavailable_samples_count
alongsidedownloadable_sample_count
is not necessarily the optimal approach, as we already know whether or not a sample isunavailable
when its loaded into the database and don't need to wait until after computed file generation. Instead, we should set it inProject::update_project_aggregate_properties
with other aggregate attributes.Solution or next step
The text was updated successfully, but these errors were encountered: