Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep demux_cell_count_estimate name for output metadata file #922

Open
avrohomgottlieb opened this issue Oct 7, 2024 · 0 comments
Open
Assignees

Comments

@avrohomgottlieb
Copy link
Contributor

avrohomgottlieb commented Oct 7, 2024

Context

We currently rename demux_cell_count_estimate to sample_cell_estimate when we're collecting Sample metadata in Sample::get_metadata. The decision was made to no longer rename this attribute for the output metadata file.

As well, we would like to assign this attribute's value in the output metadata file to be its corresponding value in the sample_cell_estimates field of the Library metadata file (which we have access to in Library.metadata). We don't plan on changing the way that the demux_sample_cell_estimate attribute is calculated in Project::update_sample_derived_properties, just the value in the output metadata file. This should be done in Library::get_metadata.

@avrohomgottlieb avrohomgottlieb self-assigned this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant