Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow messages to be tapped for the hover controls #473

Open
krschacht opened this issue Jul 23, 2024 · 0 comments
Open

Allow messages to be tapped for the hover controls #473

krschacht opened this issue Jul 23, 2024 · 0 comments
Milestone

Comments

@krschacht
Copy link
Contributor

We disabled the sticky hover situation that was tailwind falls back to on mobile in PR #371. It was creating a bad experience all around, and I still think this is the right default behavior.

The config flag was introduced by tailwind in this PR:
tailwindlabs/tailwindcss#8394

And the PR explains that enabling sticky hover for a single element (the message, in our case) should be possible with the variant: [&:group-hover]:visible. However, when I tried this simple fix it didn't work.

I need to do more testing, but it may be because we aren't on the version of tailwind that supports variants (or one-off variants). More is explained:

The tl;dr is — figure out how to make it possible for messages to be tapped to reveal their message controls, and ideally get variant's working generally since those would be nice to use (e.g. to implement a better relationship class within the app)

@krschacht krschacht added this to the 1.0 milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant