-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRI: Actually throw ENOENT for missing files #137
base: master
Are you sure you want to change the base?
Conversation
75f6a8c
to
32a4a79
Compare
Thanks for the feedback! Not sure why GitHub seems to have lost it; it can be found at mook/mkxp@75f6a8c. Made an attempt at fixing the other error codes too, but I assume they could use improvement. Checked that the test case above still passes. |
Ah, sorry, I must have commented on the commit in your fork instead of in this RP. What other error codes are wrong? |
Sorry, I just meant that I tried to sort the other physfs error codes in the same spot to other Ruby exceptions but am not confident I'm translating those correctly. I also suspect that some of the things I'm checking for can't actually occur at that point. At worst though it just means a different exception than expected. |
There are exactly two expected cases when the call comes from
Looking at the physfs header, the 2nd case would be covered by |
32a4a79
to
c05ebd7
Compare
Okay, changed to handle just those two errors. Left it as a |
…ons-windows-zip GitHub Actions: zip Windows artifact before uploading
The wrong exception (
EOFError
instead ofErrno::ENOENT
) was being raised whenload_data()
was being passed an invalid path.Test case (global scope in
Main
should do):Yes, I actually found a game that did that, and handled
Errno:ENOENT
:|