suite-subtest-run: report on usage suite.T().Run instead of suite.Run

[ArtAndreev]

According to https://github.com/stretchr/testify/blob/db8608ed63f5bd9abdd03f669f5bb80569c114b6/suite/suite.go#L96 suite.Run should be used for running subtests instead of directly running subtests with testing.T.

I ran into some problems with invalid running subtests and want this linter to report such invalid usage.

[Antonboom]

Hi, @ArtAndreev!

Thank you for request.
Do you mean CONTRIBUTING.md#suite-run?

Could you provide the concrete example this concrete problems? 🙏

P.S. Why s.T() just not return trimmed interface? 🤔 Maybe we already have known issue in testify project?

[Antonboom]

1. suite.Run() triggers data race errors with parallel tests stretchr/testify#1139
2. How do I use subtests in testify stretchr/testify#889
3. Add a Run helper method stretchr/testify#510
4. https://gophers.slack.com/archives/C92321HDJ/p1628032842014900?thread_ts=1627781651.013900&cid=C92321HDJ

[ArtAndreev]

Hi!

The problem occurs very rarely, it's hard to understand why it happens. It raises data race between tests, but the only t.Parallel call is in function that runs suite.

I have just read CONTRIBUTING.md, looks like the unimplemented checks from it should be mentioned in README.md, so I wouldn't have raised this issue. Anyway, sorry for noise 🙂.

[ArtAndreev]

Ah, already mentioned:

Also look at open for contribution checkers

Sorry for noise.

[Antonboom]

Also:

• Trying to run tests in parallel with suite fails stretchr/testify#1253
• Running Parallel Tests in Suite stretchr/testify#187
• bug in parallel tests stretchr/testify#466