From 72543fcd6833ac11050bffc4005085a7598757f8 Mon Sep 17 00:00:00 2001 From: moerwald Date: Sun, 27 Jan 2019 18:24:10 +0100 Subject: [PATCH] Replaced one line methods with expression-bodied members. Removed useless empty lines. --- src/Polly.Shared/Fallback/AsyncFallbackPolicy.cs | 7 ++----- src/Polly.Shared/Fallback/FallbackPolicy.cs | 12 +++--------- src/Polly.Shared/Fallback/IFallbackPolicy.cs | 1 - 3 files changed, 5 insertions(+), 15 deletions(-) diff --git a/src/Polly.Shared/Fallback/AsyncFallbackPolicy.cs b/src/Polly.Shared/Fallback/AsyncFallbackPolicy.cs index dcad14cc15d..351972f7a00 100644 --- a/src/Polly.Shared/Fallback/AsyncFallbackPolicy.cs +++ b/src/Polly.Shared/Fallback/AsyncFallbackPolicy.cs @@ -49,9 +49,8 @@ protected override Task ImplementationAsync( /// protected override Task ImplementationAsync(Func> action, Context context, CancellationToken cancellationToken, bool continueOnCapturedContext) - { + => throw new InvalidOperationException($"You have executed the generic .Execute<{nameof(TResult)}> method on a non-generic {nameof(FallbackPolicy)}. A non-generic {nameof(FallbackPolicy)} only defines a fallback action which returns void; it can never return a substitute {nameof(TResult)} value. To use {nameof(FallbackPolicy)} to provide fallback {nameof(TResult)} values you must define a generic fallback policy {nameof(FallbackPolicy)}<{nameof(TResult)}>. For example, define the policy as Policy<{nameof(TResult)}>.Handle.Fallback<{nameof(TResult)}>(/* some {nameof(TResult)} value or Func<..., {nameof(TResult)}> */);"); - } } /// @@ -78,8 +77,7 @@ Func, Context, CancellationToken, Task> fallbac [DebuggerStepThrough] protected override Task ImplementationAsync(Func> action, Context context, CancellationToken cancellationToken, bool continueOnCapturedContext) - { - return AsyncFallbackEngine.ImplementationAsync( + => AsyncFallbackEngine.ImplementationAsync( action, context, cancellationToken, @@ -88,6 +86,5 @@ protected override Task ImplementationAsync(Func [DebuggerStepThrough] protected override void Implementation(Action action, Context context, CancellationToken cancellationToken) - { - FallbackEngine.Implementation( + => FallbackEngine.Implementation( (ctx, token) => { action(ctx, token); return EmptyStruct.Instance; }, context, cancellationToken, @@ -35,13 +34,10 @@ protected override void Implementation(Action action ResultPredicates.None, (outcome, ctx) => _onFallback(outcome.Exception, ctx), (outcome, ctx, ct) => { _fallbackAction(outcome.Exception, ctx, ct); return EmptyStruct.Instance; }); - } /// protected override TResult Implementation(Func action, Context context, CancellationToken cancellationToken) - { - throw new InvalidOperationException($"You have executed the generic .Execute<{nameof(TResult)}> method on a non-generic {nameof(FallbackPolicy)}. A non-generic {nameof(FallbackPolicy)} only defines a fallback action which returns void; it can never return a substitute {nameof(TResult)} value. To use {nameof(FallbackPolicy)} to provide fallback {nameof(TResult)} values you must define a generic fallback policy {nameof(FallbackPolicy)}<{nameof(TResult)}>. For example, define the policy as Policy<{nameof(TResult)}>.Handle.Fallback<{nameof(TResult)}>(/* some {nameof(TResult)} value or Func<..., {nameof(TResult)}> */);"); - } + => throw new InvalidOperationException($"You have executed the generic .Execute<{nameof(TResult)}> method on a non-generic {nameof(FallbackPolicy)}. A non-generic {nameof(FallbackPolicy)} only defines a fallback action which returns void; it can never return a substitute {nameof(TResult)} value. To use {nameof(FallbackPolicy)} to provide fallback {nameof(TResult)} values you must define a generic fallback policy {nameof(FallbackPolicy)}<{nameof(TResult)}>. For example, define the policy as Policy<{nameof(TResult)}>.Handle.Fallback<{nameof(TResult)}>(/* some {nameof(TResult)} value or Func<..., {nameof(TResult)}> */);"); } /// @@ -66,8 +62,7 @@ Func, Context, CancellationToken, TResult> fallbackActio /// [DebuggerStepThrough] protected override TResult Implementation(Func action, Context context, CancellationToken cancellationToken) - { - return FallbackEngine.Implementation( + => FallbackEngine.Implementation( action, context, cancellationToken, @@ -75,6 +70,5 @@ protected override TResult Implementation(Func public interface IFallbackPolicy : IFallbackPolicy { - } }