Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When user disconnects Jetpack, WooCommerce Shipping & Tax is not listed as one of the plugins that will stop working #28870

Closed
pehaa opened this issue Feb 9, 2023 · 4 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Focus] Compatibility Ensuring our products play well with third-parties [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended User Report

Comments

@pehaa
Copy link

pehaa commented Feb 9, 2023

Impacted plugin

Jetpack

Quick summary

WooCommerce Shipping & Tax requires the Jetpack plugin activated and connected.
When a user disconnects Jetpack, they see a warning that some of the plugins will no longer work.
WooCommerce Shipping & Tax is not listed, though.

Markup 2023-02-09 at 14 46 50

Steps to reproduce

  1. Start a website, install, activate and connect Jetpack
  2. Install WooCommerce and WooCommerce Shipping & Tax plugin
  3. Disconnect Jetpack

A clear and concise description of what you expected to happen.

Users see WooCommerce Shipping & Tax in the list of plugins that will no longer work.

What actually happened

You will not see WooCommerce Shipping & Tax on the list of plugins that will no longer work

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Self-hosted

Logs or notes

No response

@pehaa pehaa added [Type] Bug When a feature is broken and / or not performing as intended Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". Involves Happiness User Report Needs triage Ticket needs to be triaged labels Feb 9, 2023
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] High labels Feb 9, 2023
@sergeymitr
Copy link
Contributor

Hi there!

All those plugins aren't dependent on Jetpack-the-plugin, but integrate the Connection package instead.
The list of connected plugins comes from the Jetpack connection configuration.

Our approach to the issue pretty much depends on whether you're planning to integrate the Connection package, or will stick to Jetpack-the-plugin being required.
If latter, we could add a filter for you to use to add WooCommerce Shipping & Tax into the list. Is this the way you'd prefer?

@pehaa
Copy link
Author

pehaa commented Feb 10, 2023

Hey @sergeymitr 👋
Thank you for replying so quickly!

Do I understand correctly that this requires decisions/changes within the WooCommerce Shipping & Tax plugin?
Either way?
Should I relay this question to the dev team behind WooCommerce Shipping & Tax (internally or create an issue in the plugin's repo and mention this one)? What's the best way to proceed?

Thank you!

@jeherve
Copy link
Member

jeherve commented Nov 21, 2023

@sergeymitr Would #33920 have helped with this issue?

@sergeymitr
Copy link
Contributor

Hi @pehaa, @jeherve.
I apologize for such a long delay, I somehow missed the pings.

Do I understand correctly that this requires decisions/changes within the WooCommerce Shipping & Tax plugin?

That is correct, the changes had to be done on the plugin's side, and they did get implemented.
WCS&T plugin got switched to the Connection package, so it no longer requires Jetpack to be installed: Automattic/woocommerce-services#2439

The PR also solved the problem discussed here, and the plugin is now displayed in the "Disconnect Jetpack" modal.
Screenshot 2023-12-06 at 17 19 09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Focus] Compatibility Ensuring our products play well with third-parties [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended User Report
Development

No branches or pull requests

3 participants