-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.4 #13613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion, allow querying subdocuments with defaults disabled Fix #13512
types: augment bson.ObjectId instead of adding on own type
…karpov15/schema-collection-options Revert "Revert "feat(schema): add collectionOptions option to schemas""
feat(query): delay converting documents into POJOs until query execution, allow querying subdocuments with defaults disabled
… nested paths Fix #13530
fix(document): allow setting keys with dots in mixed paths underneath nested paths
…r, add `createClient()` method to handle creating MongoClient
Island rhythms/gh 13510
Move all MongoDB-specific connection logic into driver layer, add `createClient()` method to handle creating MongoClient
`includeResultMetadata` option
id setter virtual
docs(guide): fix md lint
feat(connection): add `Connection.prototype.removeDb()` for removing a related connection
feat: upgrade to MongoDB Node.js driver 5.7.0
feat(model): add create option "immediateError"
feat: support generating custom cast error message with a function
vkarpov15
requested review from
Uzlopak,
hasezoey,
AbdelrahmanHafez and
IslandRhythms
July 14, 2023 20:15
hasezoey
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, works with current latest typegoose without problems
though some things to note:
- all
Schema.Types.*.setters
properties seem to not have any jsdoc associated with them
AbdelrahmanHafez
approved these changes
Jul 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…other than "textScore" for $meta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Examples