Stats / i18n: abbreviated month names aren't localized

[codebykat]

Reported in 2444419-t:

I recently noticed that the abbreviated month names in the stats screens aren't localized again. I've reported something similar in the past (https://en.forums.wordpress.com/topic/i18n-date-in-stats-screen) when the stats screen changed the last time. See my screenshot for further details:

FYI @gibrown since you fixed it last time :)

[timmyc]

moment.js gives us a utility to properly display these localized short month names via monthsShort but it appears our translation files only have the en-us translation for this array, see fr.json for an example - the monthsShort array is:

"monthsShort":["Jan","Feb","Mar","Apr","May","Jun","Jul","Aug","Sep","Oct","Nov","Dec"]

Long month names _are_translated, but will not visually work in most areas ( like the month labels here ) so we can't go that route.

@rralian do you happen to know how we can update the monthsShort in our translation files?

[timmyc]

Plot ( or shall I say glot ) thickens... it appears the base short month translations are just incorrect across the board, because short month names are also invalid in atlas stats:

[timmyc]

And incorrect abbreviated months can also be seen in the tooltips on this chart, and on the "Streak" shown in the insights page.

[rralian]

I think the back-end has changed around a fair bit since I've touched it last. The logic isn't in calypso itself, but rather the back-end used to generate those files. I believe there is some work in place to make use of moment's locale files within that back-end code to generate the final i18n files. You might have more luck pinging @akirk directly.

[akirk]

This is fixed now through an update of our WordPress month shortnames.

[timmyc]

@akirk thanks for fixing this!