Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing: fix Warning: Failed propType notice #1750

Closed
jkudish opened this issue Dec 17, 2015 · 2 comments
Closed

Sharing: fix Warning: Failed propType notice #1750

jkudish opened this issue Dec 17, 2015 · 2 comments
Assignees
@aduth
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. [Type] Bug

Comments

@jkudish
Copy link
Contributor

jkudish commented Dec 17, 2015

Accessing the Sharing screen I get the following notice as a non-administrator:

Warning: Failed propType: Invalid prop `label` supplied to `SharingServiceExample`. Check the render method of `SharingServiceExamples`.

Initially reported in #1653 (comment)
@jkudish jkudish added [Feature] Post/Page Editor The editor for editing posts and pages. [Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. labels Dec 17, 2015
@aduth aduth mentioned this issue Dec 18, 2015
Merged
@aduth
Copy link
Contributor

aduth commented Dec 18, 2015

This warning is shown regardless of user role.

@lancewillett lancewillett changed the title Sharing: notice for non-administrators Sharing: fix Warning: Failed propType notice Dec 18, 2015
@aduth
Copy link
Contributor

aduth commented Dec 18, 2015

Fixed by #1653.

@aduth aduth closed this as completed Dec 18, 2015
@awaisab172 awaisab172 mentioned this issue Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aduth aduth

Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. [Type] Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lancewillett @jkudish @aduth