Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup: move MLB flow to Calypso #431

Closed
oskosk opened this issue Nov 22, 2015 · 5 comments
Closed

Signup: move MLB flow to Calypso #431

oskosk opened this issue Nov 22, 2015 · 5 comments
Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. [Type] Task

Comments

@oskosk
Copy link
Contributor

oskosk commented Nov 22, 2015

The current MLB signup flow is outside of Calypso

The current MLB signup flow is outside of Calypso and it doesn’t look great. Let’s make it better :-)
[Look at] Signup framework docs to make things easier.
-- Original issue created by @nb

cc @scruffian

@oskosk oskosk added the [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. label Nov 22, 2015
@oskosk
Copy link
Contributor Author

oskosk commented Nov 23, 2015

This task is being implemented by :

Nov27 updates

Will

  • Make mlb-theme-selection step reuse component Theme.

Features to recreate

  • Link to MLB.com/blogs on team/theme selection step. Text: Welcome to MLB.com/blogs. After choosing your team and theme below you'll be ready to start blogging.
  • Team selection (Defaulting to generic MLB theme set). Specific Team themes are implemented as * Theme Options* inside the 3 available partner-mlb-??? themes and not as individual themes.
  • Theme selection
    • Fan
    • Modern
    • Retro
  • Link to Terms of Use on team/theme selection step. Text: By clicking continue, you understand that activating an MLB.com/blogs account indicates your acceptance of the Terms of Use.
  • Continue (button) on team/theme selection step
  • Domain selection with proposal of free .mlblogs.com domain and regular .wordpress.com domains and prices.
  • User account creation in case user is not authenticated.

Observations

  • Current MLB flow seems to get stuck on domain selection if the user does not select a team/theme an clicks the Continue button.
  • Current MLB flow does not select specific team-theme chosen by the user.
  • MLB team-based themes are implemented as Theme Options on each of the mlb themes:partner-mlb-fan, partner-mlb-modern, partner-mlb-retro.

Doubts

  • Should the mlb-theme step show a customized layout with special MLB background images?

Internal checklist

  • Figure out how current MLB signup flow works.
  • Analyse a working example of calypso flow.
  • Create hello-world flow.
  • Rename hello-world flow to mlb.
  • Create an account using current flow
  • Create an account using new flow
  • Get a good format on save plugin for Atom Editor compatible with current .esformatter based styling proposition. Ask for advice on this.
  • Figure out how a flow and/or step is tested.

@oskosk
Copy link
Contributor Author

oskosk commented Nov 23, 2015

This is a screencast of the MLB-theme-selection step sample built for getting used to underlying codebase. It's functional but still needs to be tuned up after some feedback.
MLB theme selection sample

What is this?!!! A screencast for ants?!!!

@scruffian
Copy link
Member

Get a good format on save plugin for Atom Editor customized compatible with current .esformatter based styling proposition. Ask for advice on this.

Good luck with this. Everyone is having problems.

@scruffian
Copy link
Member

Should the mlb-theme step show a customized layout with special MLB background images?

This is not necessary right now.

@nb nb mentioned this issue Nov 25, 2015
10 tasks
@lancewillett
Copy link
Contributor

Closing as abandoned — feel free to re-open in the future if we revisit it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. [Type] Task
Projects
None yet
Development

No branches or pull requests

4 participants