Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notices: Sass @extend directive should not be used inside a @media directive #438

Closed
lancewillett opened this issue Nov 22, 2015 · 2 comments
Labels

Comments

@lancewillett
Copy link
Contributor

Currently, libsass (and so node-sass) support a buggy version of @extend inside @media, but the spec is not supposed to allow it. libsass will be adhering to the spec in its next version: sass/libsass#712 sass/libsass@d68cc86

http://sass-compatibility.github.io/#cross_media_extend

There are plans to eventually allow these "cross media @extends", but no timeline: sass/sass#1050

We're doing this in alerts:

@extend %noticon;
, which will break after some upgrade of node-sass.

@lancewillett
Copy link
Contributor Author

CC @rickybanister in case this is part of moving Notices to gridicons.

@lancewillett lancewillett added Good First Issue Small, contained issues. and removed Design labels Dec 4, 2015
@lancewillett
Copy link
Contributor Author

This was fixed in c5f3d59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant