Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: keyboard shortcuts button is viewable on a touch device #4708

Closed
davewhitley opened this issue Apr 13, 2016 · 1 comment
Closed

Editor: keyboard shortcuts button is viewable on a touch device #4708

davewhitley opened this issue Apr 13, 2016 · 1 comment
Labels
[Feature] Post/Page Editor The editor for editing posts and pages.

Comments

@davewhitley
Copy link
Contributor

What I expected

I did not expect to see the keyboard shortcuts button on my device that did not have a keyboard.

Screenshot / Video

7rjkea1aaaaaelftksuqmcc

@davewhitley davewhitley added the [Feature] Post/Page Editor The editor for editing posts and pages. label Apr 13, 2016
@nylen
Copy link
Contributor

nylen commented Apr 13, 2016

This is not possible. The browser doesn't offer an API to determine whether the device has a keyboard.

There are also lots of edge cases like touch+keyboard laptops, even devices where the keyboard is sometimes available and sometimes not. More info about why hardware capabilities detection in general is problematic - http://stackoverflow.com/a/18001239/106302 and our touchDetect in particular - #1479

@nylen nylen closed this as completed Apr 13, 2016
@scruffian scruffian changed the title Editor: keyboard shortcuts button is viewable on a touch device Editor: keyboard shortcuts button is viewable on a touch device Apr 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Post/Page Editor The editor for editing posts and pages.
Projects
None yet
Development

No branches or pull requests

3 participants