Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't reproduce Axelrod's results #1245

Closed
marnixlenoble opened this issue May 17, 2019 · 3 comments
Closed

Can't reproduce Axelrod's results #1245

marnixlenoble opened this issue May 17, 2019 · 3 comments

Comments

@marnixlenoble
Copy link

If I create a tournament with axelrods first strategies Tit for Tat comes in 8th whereas it should be the winner as per the original outcome.

players = [
    axl.TitForTat(),
    axl.TidemanAndChieruzzi(),
    axl.Nydegger(),
    axl.Grofman(),
    axl.Shubik(),
    axl.SteinAndRapoport(),
    axl.Grudger(),
    axl.Davis(),
    axl.RevisedDowning(revised=False),
    axl.Feld(),
    axl.Joss(),
    axl.Tullock(),
    axl.UnnamedStrategy(),
    axl.Random()
]

tournament = axl.Tournament(players)
results = tournament.play()
print(results.ranked_names)
print(results.summarise())
@drvinceknight
Copy link
Member

Hi @marnixlenoble, there are two reasons for this:

  1. You are not currently running with all the strategies from Axelrod's tournament (https://axelrod.readthedocs.io/en/stable/reference/overview_of_strategies.html#axelrod-s-first-tournament) as Graaskamp is missing. It has however been implemented in Add Graaskamp (final missing strategy from Axelrod's first tournament) #1244 but I've just not gotten around to do a new release (I'll aim to do that later today!).
  2. Even with all the strategies implemented it is possible that they do not match the results reported. This could be due to poor descriptions of the originals (so implementations are as correct as possible) or incorrect reporting of results and/or incorrect implementations although the implementations in the library are fully tested, open and have been carefully reviewed.

@marcharper
Copy link
Member

Also, how many iterations did you run? There's no guarantee that TFT will win every possible instance of the tournament.

@marnixlenoble
Copy link
Author

Thank you for the speedy response. @drvinceknight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants