Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a possibility to work with aggregates having immutable identifier (e.g. data class with a val) #29

Open
zambrovski opened this issue Sep 17, 2020 · 5 comments
Open

Create a possibility to work with aggregates having immutable identifier (e.g. data class with a val) #29

zambrovski opened this issue Sep 17, 2020 · 5 comments
Labels
Priority 2: Should Status: In Progress Type: Feature

Comments

@zambrovski
Copy link
Collaborator

zambrovski commented Sep 17, 2020 •
edited
Loading

Kotlin immutability is a strong feature. Based on Java implementation, aggregates members have to be mutable, to be able to get modified from the event sourcing handlers (including the aggregate identifier).

As shown on Event-Driven-Microservices 2019 conference, this can be changed (shown in Scala) by providing a special aggregate factory, which creates aggregates with at least immutable aggregate identifier.
@zambrovski
Copy link
Collaborator Author

zambrovski commented Sep 22, 2020 •
edited
Loading

I have a running implementation on that. Thanks to Jan-Hendrick scala pitch...

@jangalinski
Copy link
Collaborator

Then we have to re-record that part of our presentation ... :-)

@zambrovski zambrovski changed the title Create a possibility to work with immutable aggregates Create a possibility to work with aggregates having immutable identifier (e.g. data class with a val) Sep 22, 2020
@zambrovski zambrovski mentioned this issue Sep 22, 2020
Open
@sandjelkovic sandjelkovic added this to the Release 0.2.0 milestone Oct 14, 2020
@smcvb smcvb modified the milestones: Release 0.2.0, Release 0.3.0 Oct 12, 2021
@smcvb
Copy link
Member

smcvb commented Oct 12, 2021

Adjusted the milestone of this issue, and the pull request, to 0.3.0.
I have done this in favor of doing a Kotlin Extension release once more.

@zambrovski
Copy link
Collaborator Author

Do you think it is required to split the PR into non-spring only and spring config by any means? Is it possible to discuss missing features in the Spring-part instead?

@smcvb
Copy link
Member

smcvb commented Oct 15, 2021

I've left a more thorough comment on the pull request just now! Let me know what you think @zambrovski.

@smcvb smcvb removed this from the Release 0.3.0 milestone Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority 2: Should Status: In Progress Type: Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zambrovski @jangalinski @smcvb @sandjelkovic