Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions fail during OIDC login using azure/login@v1 in combination with Az.Accounts/3.0.0 #118

Closed
coriet opened this issue Jun 17, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@coriet
Copy link

coriet commented Jun 17, 2024

The generated github workflow files still use the azure/login@v1 module. This in combination with the Az.Accounts/3.0.0 module leads to an OIDC authentication error, as discussed here: Azure/login#447

Expected Behavior

Successful deployment of ALZ

Current Behavior

All workflows break in the OIDC auth phase:

Error: Login failed with SyntaxError: Unexpected token R in JSON at position 0. Double check if the 'auth-type' is correct. Refer to https://github.com/Azure/login#readme for more information.

Possible Solution

Change version of azure/login@v1 to azure/login@v2 for generated workflow files.

Steps to Reproduce

  1. Generate bicep landing zone files using the ALZ module
  2. Push to GitHub
  3. Workflows get triggered automatically and fail during OIDC login stage

Context (Environment)

  • Operating System and version as reported by $PSVersionTable.OS: Windows 11 Enterprise, 10.0.22631 Build 22631
  • PowerShell versions as reported by $PSVersionTable.PSEdition: 7.4.2

Detailed Description

GitHub action workflows fail when authenticating, related to compatibility issues of "azure/login@v1" and "Az.Accounts/3.0.0".
More details here: Azure/login#447

@coriet coriet added the bug Something isn't working label Jun 17, 2024
@oZakari oZakari self-assigned this Jul 11, 2024
@oZakari
Copy link
Contributor

oZakari commented Jul 11, 2024

Thanks @coriet, will get this fixed and included in a new release.

@jaredfholgate
Copy link
Member

This has been released.

@coriet
Copy link
Author

coriet commented Jul 23, 2024

This has been released.

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants