Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occur unhandled runtime error when callee could not find or callee rejected an incoming call #174

Closed
bbonkr opened this issue Feb 5, 2021 · 4 comments
Assignees
Labels
Bug Something isn't working Calling Issue involves Calling functionality. JavaScript Issues involving the JavaScript SDK

Comments

@bbonkr
Copy link

bbonkr commented Feb 5, 2021

Describe the bug

Occur unhandled runtime error below condition.

  • Callee could not find.
  • Callee rejected an incoming call.

To Reproduce
Steps to reproduce the behavior:

When callee jejected an incoming call:

  1. Make a call with azure communication service identifier like 8:aaa
  2. Callee rejected an incoming call.
  3. Caller got unhandled runtime error on caller' web browser console

When callee could not find:

  1. Make a call with azure communication service identifier like 8:aaa
  2. Callee does not find such as callee does not sign in our service.
  3. Caller got unhandled runtime error on caller' web browser console

Expected behavior
Error does not occur.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Microsoft Edge, Google Chrome
  • Version 88.0.705.56 (Official build) (64-bit), 88.0.4324.104(Official build) (64-bit)
PS> node -v
v14.15.1
PS> npm -v
6.14.11

dependent packages:

  • @azure/communication-calling: ^1.0.0-beta.4
  • @azure/communication-common: ^1.0.0-beta.4
  • react: ^16.13.0
  • react-dom: ^16.13.0
  • next: ^10.0.3

Additional context
It was not case with @azure/communication-calling 1.0.0-beta 3

When callee rejected an incoming call.

caller-error
caller-error-2

When call could not find.

caller-error-3
caller-error-4

Logs

Web browser console log

Uncaught (in promise) 47
setTimeout (async)
handleIncomingNotification @ sdk.bundle.js:131
e.handleMessage @ sdk.bundle.js:77
e.safeExecuteHandle @ sdk.bundle.js:141
e.handleMessage @ sdk.bundle.js:141
e.tryMessageHandlers @ sdk.bundle.js:149
e.onTrouterRequest @ sdk.bundle.js:149
e.onDownstreamRequest @ sdk.bundle.js:141
e.dispatchDownstreamRequest @ sdk.bundle.js:149
e.onDownstreamRequest @ sdk.bundle.js:149
e.onSocketMessage @ sdk.bundle.js:149
(anonymous) @ sdk.bundle.js:149
n.emit @ sdk.bundle.js:141
n.onPacket @ sdk.bundle.js:141
i.onPacket @ sdk.bundle.js:141
n.onPacket @ sdk.bundle.js:141
n.onData @ sdk.bundle.js:141
websocket.onmessage @ sdk.bundle.js:141
sdk.bundle.js:4 
Uncaught (in promise) Error: Failed to start the call
    at CallImpl.<anonymous> (sdk.bundle.js:149)
    at Generator.throw (<anonymous>)
    at s (sdk.bundle.js:149)
CommunicationErrorImpl @ sdk.bundle.js:4
(anonymous) @ sdk.bundle.js:149
s @ sdk.bundle.js:149
Promise.then (async)
c @ sdk.bundle.js:149
(anonymous) @ sdk.bundle.js:149
__awaiter$6 @ sdk.bundle.js:149
startCallInternal @ sdk.bundle.js:149
createCall @ sdk.bundle.js:149
call @ sdk.bundle.js:149
i.value @ sdk.bundle.js:4
_callee13$ @ useAzureCommunicationService.ts:685
tryCatch @ runtime.js:63
invoke @ runtime.js:293
(anonymous) @ runtime.js:118
asyncGeneratorStep @ asyncToGenerator.js:3
_next @ asyncToGenerator.js:25
Promise.then (async)
asyncGeneratorStep @ asyncToGenerator.js:13
_next @ asyncToGenerator.js:25
(anonymous) @ asyncToGenerator.js:32
(anonymous) @ asyncToGenerator.js:21
makeCall @ useAzureCommunicationService.ts:680
(anonymous) @ GroupCall.tsx:53
commitHookEffectListMount @ react-dom.development.js:19731
commitPassiveHookEffects @ react-dom.development.js:19769
callCallback @ react-dom.development.js:188
invokeGuardedCallbackDev @ react-dom.development.js:237
invokeGuardedCallback @ react-dom.development.js:292
flushPassiveEffectsImpl @ react-dom.development.js:22853
unstable_runWithPriority @ scheduler.development.js:653
runWithPriority$1 @ react-dom.development.js:11039
flushPassiveEffects @ react-dom.development.js:22820
(anonymous) @ react-dom.development.js:22699
workLoop @ scheduler.development.js:597
flushWork @ scheduler.development.js:552
performWorkUntilDeadline @ scheduler.development.js:164
@bbonkr bbonkr added the Bug Something isn't working label Feb 5, 2021
@ghost ghost added the Needs: triage 🔍 label Feb 5, 2021
@akania
Copy link
Member

akania commented Feb 5, 2021

@bbonkr Thank you for reporting this issue, we'll provide fix in the next release

@akania akania added Calling Issue involves Calling functionality. JavaScript Issues involving the JavaScript SDK labels Feb 5, 2021
@ProbablePrime
Copy link
Contributor

@akania This bug deals with beta.4 I see beta.9 is the latest(https://www.npmjs.com/package/@azure/communication-calling)

Is this bug fixed in Beta 9?

@ghost
Copy link

ghost commented Mar 17, 2021

Hey @akania, this issue has been marked as needing attention. Please review the issue and remove the Needs: Attention label if this was done in error. Thank you!

@akania
Copy link
Member

akania commented Jun 7, 2021

Hi all, this bug was fixed, we'll close this issues - please update to latest version of library ( 1.1.0-beta.1 as of 6/6/2021 )

@akania akania closed this as completed Jun 7, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working Calling Issue involves Calling functionality. JavaScript Issues involving the JavaScript SDK
Projects
None yet
Development

No branches or pull requests

3 participants