Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS SDK: Unable to identify when the remote participant's mute and speaking states have changed #19

Closed
terrychen1122 opened this issue Sep 23, 2020 · 7 comments
Assignees
Labels
Bug Something isn't working Calling Issue involves Calling functionality. iOS Issues involving the iOS SDK

Comments

@terrychen1122
Copy link

During the call, I was not able to get notified when a remote participant unmuted/muted or was speaking.

To Reproduce:

  1. Establish a call
  2. Mute one participant and the other end is not able to get notified by this action

Expected behavior:
I was assuming the state of remote participant should have been changed and I could get notified by implementing the ACSRemoteParticipantDelegate protocol method (void)onParticipantStateChanged:(ACSRemoteParticipant *)remoteParticipant :(ACSPropertyChangedEventArgs *)args.

Below is the code snippet:

- (void)onRemoteParticipantsUpdated:(ACSCall *)call :(ACSParticipantsUpdatedEventArgs *)args {
    for (ACSRemoteParticipant *remoteParticipant in args.addedParticipants) {
        self.remoteParticipants[remoteParticipant.identity.getId] = remoteParticipant;
        remoteParticipant.delegate = self;
    ...
}

I also verified the other protocol method (void)onVideoStreamsUpdated:(ACSRemoteParticipant *)remoteParticipant :(ACSRemoteVideoStreamsEventArgs *)args did get called when I enabled and disabled the video stream.

If (void)onParticipantStateChanged:(ACSRemoteParticipant *)remoteParticipant :(ACSPropertyChangedEventArgs *)args is not the one I should listen for mute and speaking state changes, how could I do that?

  • Device: iPhone X
  • OS: 13.1
@raosanat
Copy link
Member

onParticipantStateChanged callback on delegate ACSRemoteParticipantDelegate should be raised when state of the remote participant changes from mute to unmute and you should be able to read the current state by reading the following property on the ACSRemoteParticipant object

/// True if the remote participant is muted
@property (readonly) BOOL isMuted;

Please give us sometime to reproduce the scenario at our end. In the meanwhile can you attach the logs of both the participants. The log file acs_sdk.log will be found in Cache folder of your app container.

@raosanat raosanat self-assigned this Sep 23, 2020
@nmurav nmurav added Bug Something isn't working Calling Issue involves Calling functionality. labels Sep 23, 2020
@terrychen1122
Copy link
Author

terrychen1122 commented Sep 24, 2020

@raosanat Is it this one? I found a file under Caches folder called acs-sdk-0-4108691083.blog. Zipped it and attached.
acs_sdk-0-4108691083.blog.zip

@mariusu-msft
Copy link
Member

@terrychen1122 we have confirmed this is a bug. Should be fixed in an upcoming release. Currently targeting the week of 10/6.

cc: @raosanat

@raosanat
Copy link
Member

raosanat commented Oct 7, 2020

@terrychen1122 We have made a release which fixes this issue. Here is the link to the release AzureCommunicationCalling - v1.0.0-beta.4
Please verify if the bug is fixed in this new release. Thanks.

@terrychen1122
Copy link
Author

Thanks @raosanat . since we have new protocol methods, when the mute state changes, are we getting both onParticipantStateChanged and onIsMutedChanged or just getting onIsMutedChanged?

@mariusu-msft
Copy link
Member

@terrychen1122 you will only get onIsMutedChanged. onParticipantStateChanged will get called only if the in-call state of the participant changes, such as transitioning between Connected and Disconnected.

Please let us know if you have any feedback in general about the API. As part of our Public Preview we are trying to capture as much feedback as possible.

@mariusu-msft
Copy link
Member

Closing the issue as this should be fixed in latest release.

Thanks @terrychen1122 for the report!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 15, 2020
@mariusu-msft mariusu-msft added the iOS Issues involving the iOS SDK label Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working Calling Issue involves Calling functionality. iOS Issues involving the iOS SDK
Projects
None yet
Development

No branches or pull requests

5 participants