Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web] Use web client over file:// urls #297

Closed
marko opened this issue May 24, 2021 · 1 comment
Closed

[Web] Use web client over file:// urls #297

marko opened this issue May 24, 2021 · 1 comment
Assignees
@akania
Labels
ADO Linked This issue has an ADO Item on our ADO. Bug Something isn't working Calling Issue involves Calling functionality. JavaScript Issues involving the JavaScript SDK

Comments

@marko
Copy link

marko commented May 24, 2021

Describe the bug
The web SDK requires HTTPS or localhost, as WebRTC APIs require a secure context.

file:// URLs are also considered secure, but are not allowed by the SDK.

The SDK currently throws an exception if "https:" !== location.protocol && "localhost" !== location.hostname

Expected behavior
The web SDK should work if opened through a file:// URL.
@marko marko added the Bug Something isn't working label May 24, 2021
@ghost ghost added the Needs: triage 🔍 label May 24, 2021
@akania akania added Calling Issue involves Calling functionality. JavaScript Issues involving the JavaScript SDK and removed Needs: triage 🔍 labels May 24, 2021
@RinaRish RinaRish added the ADO Linked This issue has an ADO Item on our ADO. label Jun 4, 2021
@mariusu-msft
Copy link
Member

This is now fixed in latest beta SDKs. Closing issue.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@akania akania

Labels
ADO Linked This issue has an ADO Item on our ADO. Bug Something isn't working Calling Issue involves Calling functionality. JavaScript Issues involving the JavaScript SDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@akania @RinaRish @marko @mariusu-msft