Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PSRule] Integrate PSRule pre-flight checks with ADO module validation workflows #2427

Open
Tracked by #2149
eriqua opened this issue Dec 10, 2022 · 2 comments
Open
Tracked by #2149
Labels
blocked if an issue is blocked [cat] azure devops category: Azure DevOps [cat] needs further discussion [cat] pipelines category: pipelines [cat] testing category: testing enhancement New feature or request

Comments

@eriqua
Copy link
Contributor

eriqua commented Dec 10, 2022

This is the ADO version of issue #2426.

This is a separate issue wrt the GH one for the following reason:

As noticed during PoC (ref #2026) the PSRule ADO extension prerequisite may be a blocker to adopting the analyzer in ADO pipelines, since the current extension is not released with a Microsoft verified publisher.

A workaround to be discussed for CARML is to replace the action with custom script using PSRule module and cmdlets, getting rid of the extension prerequisite, but likely requiring more effort.

Alternatively, since a new ADO extension is planned to be released with a Microsoft verified publisher, we may want to block this issue until then. This is tracked by microsoft/PSRule-pipelines#513,

A first implementation of this issue for, e.g., the KV module, is hosted by branch hack/topic6. The branch leverages the currently published extension.

@eriqua eriqua added enhancement New feature or request [cat] pipelines category: pipelines [cat] testing category: testing [cat] azure devops category: Azure DevOps labels Dec 10, 2022
@eriqua
Copy link
Contributor Author

eriqua commented Dec 10, 2022

Suggestion: apply the needsfurtherdiscussion label.

Discuss if blocking the issue until microsoft/PSRule-pipelines#513 completion

@rahalan
Copy link
Contributor

rahalan commented Dec 13, 2022

Should be discussed after the other PSRule issues are implemented

@AlexanderSehr AlexanderSehr added this to the Azure Verfified Modules (AVM) - CI Issues milestone May 19, 2024
@AlexanderSehr AlexanderSehr removed this from the Azure Verfified Modules (AVM) - CI Issues milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked if an issue is blocked [cat] azure devops category: Azure DevOps [cat] needs further discussion [cat] pipelines category: pipelines [cat] testing category: testing enhancement New feature or request
Projects
Status: Blocked
Development

No branches or pull requests

3 participants