Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report]: Remove extra } in Microsoft.EventHub\namespaces\eventhubs\.bicep\nested_roleassignments.bicep #3166

Closed
akata72 opened this issue May 4, 2023 · 4 comments · Fixed by #3243
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@akata72
Copy link
Contributor

akata72 commented May 4, 2023

Describe the bug

There is an extra } at the end of line 58 in this file. (good-first-issue) :-) This is causing the existing reference to fail during deployment.

To reproduce

Use the module.

Code snippet

No response

Relevant log output

No response

@akata72 akata72 added the bug Something isn't working label May 4, 2023
@AlexanderSehr AlexanderSehr added the good first issue Good for newcomers label May 5, 2023
@AlexanderSehr
Copy link
Contributor

AlexanderSehr commented May 5, 2023

Hey @akata72, thanks for sharing. It's indeed a good first issue.

@AlexanderSehr
Copy link
Contributor

I would also suggest to add the role assignment to the common test case. This should have catched this error ... 17 months ago :D

@akata72
Copy link
Contributor Author

akata72 commented May 5, 2023

Hm..you are right. Looks like this was fixed at some point. Must be an issue with our fork (not being updated).

@AlexanderSehr
Copy link
Contributor

No no @akata72, you're absolutely right. I was looking into the namespaces/nested_roleassignments.bicep, but you were referring to the eventhubs child module. There it IS actually wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

3 participants