Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Microsoft Generator CSharp] Migrate Writers: Writer Helpers #4347

Open
2 of 3 tasks
Tracked by #4199
jorgerangel-msft opened this issue Mar 6, 2024 · 3 comments
Open
2 of 3 tasks
Tracked by #4199

Comments

@jorgerangel-msft
Copy link
Member

jorgerangel-msft commented Mar 6, 2024

The writer helper classes should be migrated and stripped of any branding.

Classes to migrate:

Tasks

  1. MGC
  2. 3 of 3
    Epic MGC
    ShivangiReja
  3. MGC
@m-nash
Copy link
Member

m-nash commented Mar 26, 2024

@AlexanderSher can you update with which of these will exist.

@m-nash
Copy link
Member

m-nash commented Apr 9, 2024

@jorgerangel-msft can we split this up to 1 issue per class and put them in mid may iterations

@ArcturusZhang
Copy link
Member

ArcturusZhang commented Apr 12, 2024

@AlexanderSher @m-nash I hope there could be a refactor around these types such as Alexander has done in his consolidation PR before we "migrate" them there because these "writer" helpers are really messy and not following the principal we would like to establish that the writers should just know nothing about what it is writing and everything should be prepared and built in the type provider (including models and clients).
I feel quite a lot pain while making the changes to update SCM around them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants