Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cadl RLC] Fix the extensible enum issue and support apiVersion default value suggested from cadl-dpg #1667

Closed
2 tasks done
MaryGao opened this issue Nov 22, 2022 · 0 comments · Fixed by #1674 or #1676
Closed
2 tasks done
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. DPG/RLC v2.0b2 Epic: Model Generation https://github.com/Azure/cadl-azure/issues/1944 RLC WS: Code Generation

Comments

@MaryGao
Copy link
Member

MaryGao commented Nov 22, 2022

  • Fix the extensible enum issue
  • Support apiVersion default value suggested from cadl-dpg

In this pr we handle the cadl extensible enum as string literal, I think the more consistent way is handled as string. See our current type map test cases here.

previous implementation:

export default function createClient(
Endpoint: string,
ApiVersion: "v1.1",
credentials: KeyCredential,
options: ClientOptions = {}
): AnomalyDetectorClient {

Current pr:

/**
* Initialize a new instance of the class testClient class.
* @param Endpoint type: string The endpoint to use.
* @param Version type: string The version to use. Possible values: v1.1
*/
export default function createClient(
Endpoint: string,
Version: string,
options: ClientOptions = {}
): testClient {

draft pr is here: #1664

@MaryGao MaryGao changed the title [Cadl RLC]Support the default value in apiVersion [Cadl RLC] Fix the extensible enum issue and support default value suggested from cadl-dpg Nov 22, 2022
@MaryGao MaryGao changed the title [Cadl RLC] Fix the extensible enum issue and support default value suggested from cadl-dpg [Cadl RLC] Fix the extensible enum issue and support apiVersion default value suggested from cadl-dpg Nov 22, 2022
@MaryGao MaryGao self-assigned this Nov 22, 2022
@MaryGao MaryGao added Client This issue points to a problem in the data-plane of the library. DPG/RLC v2.0b2 Epic: Model Generation https://github.com/Azure/cadl-azure/issues/1944 RLC labels Nov 22, 2022
@MaryGao MaryGao removed their assignment Nov 22, 2022
@MaryGao MaryGao self-assigned this Nov 22, 2022
@chunyu3 chunyu3 reopened this Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. DPG/RLC v2.0b2 Epic: Model Generation https://github.com/Azure/cadl-azure/issues/1944 RLC WS: Code Generation
Projects
None yet
2 participants