Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we not export PagedResult to top-level index in modular? #2604

Closed
kazrael2119 opened this issue Jun 19, 2024 · 1 comment · Fixed by #2620
Closed

Should we not export PagedResult to top-level index in modular? #2604

kazrael2119 opened this issue Jun 19, 2024 · 1 comment · Fixed by #2620
Assignees
@qiaozha
Labels
HRLC p0 priority 0

Comments

@kazrael2119
Copy link
Contributor

kazrael2119 commented Jun 19, 2024 •
edited by MaryGao
Loading

Model PagedOperation is used in an internal function but now it exports to top-level index.

Considering this is only internal used and we don't need to export them to public.
@MaryGao MaryGao changed the title Internal model should not export to top-level index Should we export PagedResult to top-level index in modular? Jun 19, 2024
@MaryGao MaryGao changed the title Should we export PagedResult to top-level index in modular? Should we not export PagedResult to top-level index in modular? Jun 20, 2024
@MaryGao
Copy link
Member

MaryGao commented Jun 24, 2024

similar issue in hlc #1698

@qiaozha qiaozha added HRLC p0 priority 0 labels Jun 26, 2024
@qiaozha qiaozha mentioned this issue Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qiaozha qiaozha

Labels
HRLC p0 priority 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

should-not-export-paged-result-model qiaozha/autorest.typescript
3 participants
@MaryGao @qiaozha @kazrael2119