Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAL to MSAL migration #18944

Closed
jiasli opened this issue Jul 21, 2021 · 11 comments · Fixed by #19853
Closed

ADAL to MSAL migration #18944

jiasli opened this issue Jul 21, 2021 · 11 comments · Fixed by #19853

Comments

@jiasli
Copy link
Member

jiasli commented Jul 21, 2021

As ADAL has been deprecated:

This library, ADAL for Python, will no longer receive new feature improvements. Instead, use the new library
MSAL for Python.

Azure CLI needs to be migrated from ADAL to MSAL.

References

@ghost ghost added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Jul 21, 2021
@jiasli jiasli self-assigned this Jul 21, 2021
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Jul 21, 2021
@yonzhan yonzhan added the MSAL label Jul 21, 2021
@yonzhan yonzhan added this to the Backlog milestone Jul 21, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 21, 2021

The rough ETA for GA is the end of October.

@ploegert
Copy link

@yonzhan - is this still targeted for end of oct 2021 completion? Thanks!

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 25, 2021

@ploegert yes, it is still on track

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 26, 2021

Overall 30% completed:We implemented cross-tenant support for MSAL integration GA and the next step is Unit Test and E2E Test based on latest MSAL 1.14.0 AzureAD/microsoft-authentication-library-for-python#400

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 23, 2021

Overall 60% completed: We finished testing based on latest MSAL 1.14.0 and we are working on Unit Test and E2E Test.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 6, 2021

Overall 75% completed: The unit tests for Azure CLI’s MSAL integration have been completed. All tests in CI show pass. Meanwhile, we need all team members to perform E2E tests on MSAL-based CLI. We will also invite other teams, like GitHub Action team, which are interested to test it too. Therefore, we plan to release a Beta version in the middle of October before the final GA release.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 14, 2021

Overall 90% finished. Remaining work includes:

  • E2E tests for Ignite-related features
  • E2E tests for sovereign clouds and Azure Stack
  • Release a beta version on 2021-10-15 before the final GA
  • Deliver the beta version to related teams including GitHub Action team for full E2E test

@jiasli
Copy link
Member Author

jiasli commented Oct 21, 2021

We have released MSAL-based Azure CLI Beta 2.29.0.post20211020122330. You may follow https://docs.microsoft.com/en-us/cli/azure/install-azure-cli-beta to install it, or upgrade it in the previous virtual environment:

pip install --extra-index-url https://azcliprod.blob.core.windows.net/beta/simple/ --upgrade azure-cli

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 21, 2021

Overall 95% finished, with all major tests passed. We are still testing for edge cases, like proxy, long-running operations, etc.

@jiasli
Copy link
Member Author

jiasli commented Nov 3, 2021

Azure CLI 2.30.0 has been released which uses MSAL as the underlying authentication library. For more details, please see https://docs.microsoft.com/en-us/cli/azure/msal-based-azure-cli.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 3, 2021

Finally, we achieved 100% :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants