Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

az ad app update --add replyUrls overwrites app registration #9375

Closed
midgleyc opened this issue May 13, 2019 · 5 comments
Closed

az ad app update --add replyUrls overwrites app registration #9375

midgleyc opened this issue May 13, 2019 · 5 comments
Assignees
Milestone

Comments

@midgleyc
Copy link

Describe the bug
az ad app update --add replyUrls overwrites the replyUrls field instead of adding to it

To Reproduce

  1. Create a new app registration. Record the object ID OBJ_ID
  2. Add a Reply Url of https://example.com/test
  3. Run az ad app update --id "OBJ_ID" --add replyUrls "https://example.com/test2"

Expected behavior
The reply Urls list should contain both https://example.com/test and https://example.com/test2

Environment summary
WSL version 2.0.64

Additional context
Based on --debug output, this is correctly sending a PATCH request. Either I've misintepreted the syntax, this is a REST API bug, or the REST API isn't supposed to be able to handle this call. If the second option, can this be forwarded to the correct team?

@yugangw-msft yugangw-msft added the Graph az ad label May 13, 2019
@yugangw-msft
Copy link
Contributor

It is bug that we should fix.

@abrignola
Copy link

Hi, when will this fix be available? The current version of the cli 2.0.75 is still overwriting the replyurls

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 26, 2019

@jiasli please take a look.

@abrignola
Copy link

any update on this?

@jiasli
Copy link
Member

jiasli commented Apr 10, 2020

Hi @abrignola, this issue is already addressed.

> az ad app show --id 93dde3da-9fca-47dd-aee2-409b402ffed3

  "replyUrls": [
    "https://myapp.com"
  ],

> az ad app update --id 93dde3da-9fca-47dd-aee2-409b402ffed3 --add replyUrls "https://example.com/test"

> az ad app show --id 93dde3da-9fca-47dd-aee2-409b402ffed3

  "replyUrls": [
    "https://myapp.com",
    "https://example.com/test"
  ],

For MS Graph approach, you may refer to #9501 (comment). (Also see #12946)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants