[Virtual Machine Extension] schema for protectedSettingsFromKeyVault is not clear

[myc2h6o]

Hi, I'm onboarding protectedSettingsFromKeyVault in Terraform, but the schema seems not quite clear to me. In the Swagger, it is a plain object without any specific properties inside it. But from the example, it seems like it's only accepting a key vault id and the secret url. Is below the only acceptable properties for protectedSettingsFromKeyVault or it can accept other properties as wel?

azure-rest-api-specs/specification/compute/resource-manager/Microsoft.Compute/stable/2022-03-01/ComputeRP/virtualMachine.json

Lines 1955 to 1958 in 28db62c

	"protectedSettingsFromKeyVault": {
	"type": "object",
	"description": "The extensions protected settings that are passed by reference, and consumed from key vault"
	}

azure-rest-api-specs/specification/compute/resource-manager/Microsoft.Compute/stable/2022-03-01/ComputeRP/examples/virtualMachineExamples/VirtualMachineExtensions_Update.json

Lines 18 to 22 in 28db62c

	"protectedSettingsFromKeyVault": {
	"sourceVault": {
	"id": "/subscriptions/a53f7094-a16c-47af-abe4-b05c05d0d79a/resourceGroups/myResourceGroup/providers/Microsoft.KeyVault/vaults/kvName"
	},
	"secretUrl": "https://kvName.vault.azure.net/secrets/secretName/79b88b3a6f5440ffb2e73e44a0db712e"

[Drewm3]

It does look like this is a bug in the swagger, at least on first inspection. @sandeepraichura, could you look into this with the VM Extensions dev team to confirm that this is actually a swagger bug, and work to get the bug fixed in an upcoming swagger update.

[Drewm3]

Correcting this to actually @MsGabsta who is the right owner. (Sorry Gabby)

[MsGabsta]

@Drewm3, I will look into this with the VM Extensions Dev Team.

[MsGabsta]

@myc2h6o thank you for opening this issue, it is indeed a bug. We are working on fixing this, no eta currently.

[myc2h6o]

I noticed this is fixed in 2022-08-01

azure-rest-api-specs/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2022-08-01/virtualMachine.json

Lines 1961 to 1964 in 4b5fe2f

	"protectedSettingsFromKeyVault": {
	"$ref": "./computeRPCommon.json#/definitions/KeyVaultSecretReference",
	"description": "The extensions protected settings that are passed by reference, and consumed from key vault"
	}

[MsGabsta]

I can confirm that this issue has been resolved.

[MsGabsta]

#reassign @MsGabsta

[myc2h6o]

Thanks for the update! Please feel free to close the issue.