Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IC3 ACS Server Calling ] API Review #25626

Closed
azure-sdk opened this issue Sep 1, 2023 · 8 comments · Fixed by #25624
Closed

[IC3 ACS Server Calling ] API Review #25626

azure-sdk opened this issue Sep 1, 2023 · 8 comments · Fixed by #25624
Labels
API Review Scoping This is an issue that will track work on a specific set of API changes.

Comments

@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 1, 2023

New API Review meeting has been requested.

Service Name: IC3 ACS Server Calling
Review Created By: Vivek More
Review Date: 09/21/2023 04:00 PM PT
Onboarding Record:
PR: #25624
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: custom context

Description: To review Azure Communication Services Call Automation API's

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

@azure-sdk azure-sdk added the API Review Scoping This is an issue that will track work on a specific set of API changes. label Sep 1, 2023
@azure-sdk
Copy link
Collaborator Author

Meeting updated by Vivek More

Service Name: IC3 ACS Server Calling
Review Created By: Vivek More
Review Date: 09/21/2023 04:00 PM PT
Onboarding Record:
PR: #25624
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: here

Description: To review Azure Communication Services Call Automation API's

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

@azure-sdk
Copy link
Collaborator Author

Meeting updated by Vivek More

Service Name: IC3 ACS Server Calling
Review Created By: Vivek More
Review Date: 09/21/2023 04:00 PM PT
Onboarding Record:
PR: #25624
Hero Scenarios Link: here
Core Concepts Doc Link: here

Description: To review Azure Communication Service's Call Automation's new GA features API's

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

1 similar comment
@azure-sdk
Copy link
Collaborator Author

Meeting updated by Vivek More

Service Name: IC3 ACS Server Calling
Review Created By: Vivek More
Review Date: 09/21/2023 04:00 PM PT
Onboarding Record:
PR: #25624
Hero Scenarios Link: here
Core Concepts Doc Link: here

Description: To review Azure Communication Service's Call Automation's new GA features API's

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

@azure-sdk
Copy link
Collaborator Author

Meeting updated by Vivek More

Service Name: IC3 ACS Server Calling
Review Created By: Vivek More
Review Date: 09/21/2023 04:00 PM PT
Onboarding Record:
PR: #25624
Hero Scenarios Link: here
Core Concepts Doc Link: here

Description: To review Azure Communication Service's Call Automation's new GA features API's

Hero scenarios

DTMF Actions: https://learn.microsoft.com/en-us/azure/communication-services/how-tos/call-automation/control-mid-call-media-actions?tabs=csharp
Play with AI: https://learn.microsoft.com/en-us/azure/communication-services/how-tos/call-automation/play-ai-action?pivots=programming-language-csharp
Recognize with AI: https://learn.microsoft.com/en-us/azure/communication-services/how-tos/call-automation/recognize-ai-action?source=recommendations&pivots=programming-language-csharp

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

@mikekistler
Copy link
Member

mikekistler commented Sep 22, 2023

Notes from API Review meeting, 9/21/23

  • How does it work? continuous DTMF recognition active and doing a recognize on top.
  • How is the Cog Svc Speech service associated with ACS? managed identity with mgmt plane.
  • Should the callback URIs include "override" to indicate that it overrides
  • Consider naming the succeeded and failed events with a common prefix so that they show up next to each other in the docs
  • Canceled is preferable to Cancelled
  • Consider if the endpoint could be customizable/plugable to support OpenAI or external services in the future
  • Why is ChoiceResult not showing up in the APIView ?
  • Playsource - it this polymorphic, but it started as not polymorphic, so its a bit strange

This looks good for GA, but consider the structuring of the AI endpoint configuration for future proofing.

@azure-sdk
Copy link
Collaborator Author

New API Review meeting has been requested.

Service Name: IC3 ACS Server Calling
Review Created By: Vivek More
Review Date: 11/16/2023 04:00 PM PT
Onboarding Record:
PR: #25624
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided

Description:

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

@heaths
Copy link
Member

heaths commented Nov 17, 2023

  • Main change we're reviewing today was a model change to CustomCallingContext based on SDK archboard feedback.
  • Add "format": "url" to CallIntelligenceOptions.cognitiveServiceEndpoint.
  • APIView shows 5 new endpoints, but apparently those were reviewed before. We need to double check on that and will further review on GitHub as needed.

@vivekmore-msft
Copy link
Member

vivekmore-msft commented Nov 23, 2023

  • Main change we're reviewing today was a model change to CustomCallingContext based on SDK archboard feedback.
  • Add "format": "url" to CallIntelligenceOptions.cognitiveServiceEndpoint.

@heaths As per discussion with @tg-msft, considering we are in GA already and our callbackuri is already a string without a format parameter, we will keep as it is for this GA and will reconsider this change in next iteration

  • APIView shows 5 new endpoints, but apparently those were reviewed before. We need to double check on that and will further review on GitHub as needed.

Yes, other endpoints discussed in review meeting on 09/21/2023 and feedback comments already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Review Scoping This is an issue that will track work on a specific set of API changes.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants