Template client is out-dated and needs to be updated, removing or updating ClientVersion

[ahsonkhan]

SDK authors start with the template client and might incorrectly assume we want a ClientVersion() method.

This is not what we want for SDKs, and hence the template client needs to be updated to reflect the correct pattern here.

azure-sdk-for-cpp/sdk/template/azure-template/inc/azure/template/template_client.hpp

Line 12 in 487c7ce

std::string ClientVersion() const;

cc @LarryOsterman, @RickWinter

It showed up in Attestation APIView because it started off as a template client:

azure-sdk-for-cpp/sdk/attestation/azure-security-attestation/inc/azure/attestation/attestation_client.hpp

Line 163 in af7281e

std::string const& ClientVersion() const { return m_apiVersion; }

https://apiview.dev/Assemblies/Review/5b2efd771af642728e4796813564404b#Azure::Security::Attestation::AttestationAdministrationClient

[LarryOsterman]

Removing ClientVersion from Template as a part of updating Template to match service requirements.