Investigate Vcpkg sample failure in nightly pipeline

[gearama]

No description provided.

[gearama]

[Yesterday 11:08 AM] George Arama
it's related to something from attestation :

[Yesterday 11:08 AM] George Arama
user-agent : azsdk-cpp-Attestation/1.0.0-beta.3 (Windows Server 2019 Datacenter 6.3 17763 17763.1.amd64fre.rs5_release.180914-1434) x-ms-client-request-id : c4108855-74b7-4971-7753-245d0f29cf2e [2022-05-20T20:33:56.7624737Z] DEBUG : [CURL Transport Adapter]: Creating a new session. [2022-05-20T20:33:56.7624921Z] DEBUG : [CURL Transport Adapter]: Spawn new connection. [2022-05-20T20:33:57.1414436Z] DEBUG : [CURL Transport Adapter]: No Host in request headers. Adding it [2022-05-20T20:33:57.1415057Z] DEBUG : [CURL Transport Adapter]: No content-length in headers. Adding it [2022-05-20T20:33:57.1415216Z] DEBUG : [CURL Transport Adapter]: Send request without payload [2022-05-20T20:33:57.1416308Z] DEBUG : [CURL Transport Adapter]: Windows - calling setsockopt after uploading chunk. ideal = 65536 result = 0 [2022-05-20T20:33:57.1416811Z] DEBUG : [CURL Transport Adapter]: Parse server response [2022-05-20T20:33:57.8074939Z] DEBUG : [CURL Transport Adapter]: Windows - calling setsockopt after uploading chunk. ideal = 65536 result = 0 [2022-05-20T20:33:57.8075865Z] DEBUG : [CURL Transport Adapter]: Request completed. Moving response out of session and session to response. [2022-05-20T20:33:57.8076107Z] DEBUG : [CURL Transport Adapter]: Windows - calling setsockopt after uploading chunk. ideal = 65536 result = 0 [2022-05-20T20:33:57.8076289Z] DEBUG : [CURL Transport Adapter]: Windows - calling setsockopt after uploading chunk. ideal = 65536 result = 0 [2022-05-20T20:33:57.8076884Z] DEBUG : [CURL Transport Adapter]: Windows - calling setsockopt after uploading chunk. ideal = 65536 result = 0 [2022-05-20T20:33:57.8077055Z] DEBUG : [CURL Transport Adapter]: Windows - calling setsockopt after uploading chunk. ideal = 65536 result = 0 [2022-05-20T20:33:57.8077534Z] DEBUG : [CURL Transport Adapter]: Windows - calling setsockopt after uploading chunk. ideal = 65536 result = 0 [2022-05-20T20:33:57.8077773Z] DEBUG : [CURL Transport Adapter]: Windows - calling setsockopt after uploading chunk. ideal = 65536 result = 0 [2022-05-20T20:33:57.8078262Z] DEBUG : [CURL Transport Adapter]: Windows - calling setsockopt after uploading chunk. ideal = 65536 result = 0 [2022-05-20T20:33:57.8078672Z] DEBUG : [CURL Transport Adapter]: Windows - calling setsockopt after uploading chunk. ideal = 65536 result = 0 [2022-05-20T20:33:57.8078901Z] DEBUG : [CURL Transport Adapter]: Windows - calling setsockopt after uploading chunk. ideal = 65536 result = 0 [2022-05-20T20:33:57.8079145Z] DEBUG : [CURL Transport Adapter]: Windows - calling setsockopt after uploading chunk. ideal = 65536 result = 0 [2022-05-20T20:33:57.8079308Z] DEBUG : Moving connection to pool... [2022-05-20T20:33:57.8079571Z] DEBUG : Start clean thread [2022-05-20T20:33:57.8081220Z] INFO : HTTP Response (1045ms) : 200 OK connection : keep-alive content-type : text/html; charset=UTF-8 date : Fri, 20 May 2022 20:33:57 GMT server : openresty transfer-encoding : chunked x-adblock-key : REDACTED [2022-05-20T20:33:57.8081764Z] INFO : HTTP status code 200 won't be retried. Exception: [json.exception.parse_error.101] parse error at line 1, column 1: syntax error while parsing value - invalid literal; last read: '<' *Sample returned a failed code: 1 ##[error]Bash exited with code '1'.

[Yesterday 11:21 AM] Larry Osterman
Not sure what happened without the headers from the service. Can you at least tell me the attestation instance you were using?

[Yesterday 11:22 AM] Larry Osterman
Digging in deeper. Having timestamps helps a lot.

[Yesterday 1:13 PM] Larry Osterman
ok, figured it out.

[Yesterday 1:13 PM] Larry Osterman
https://blob.com/certs returns a 200 error with an HTTP page.

[Yesterday 1:14 PM] Larry Osterman
That's not ok and can never work.

[Yesterday 1:15 PM] Larry Osterman
The vcpkg-all-smoke package needs to create an attestation resource and use it, or it needs to configure the attestation client to retrieve from a valid instance.

[Yesterday 1:15 PM] Larry Osterman
That's because creating an attestation client requires retrieving certificates from the service.

[Yesterday 1:15 PM] Larry Osterman
And https://blob.com/ is not a valid service endpoint.

[Yesterday 2:37 PM] Larry Osterman
FWIW, I updated the main.cpp file to use ATTESTATION_AAD_URL (which is created by the test-resources.json file) but it failed because the environment variable isn't found.

[Yesterday 2:38 PM] Larry Osterman
I'm not sure what to do here w.r.t. this issue. If you want to talk to the attestation service, you need an environment variable set. But that environment variable isn't set in the KeyVault CI pipeline.

[Yesterday 2:39 PM] Larry Osterman
But I'm also not sure why the vcpkg sample is being run from the keyvault pipeline.

[9:24 AM] George Arama
Thank you Larry, much appreciated.

[9:30 AM] Larry Osterman
Not sure what to do with this info though . As best as I can figure the vcpkg sample is pretty busted because it (a) is only deployed in the KV nightly pipelines (arguably it should be in all services) and (b) depends on KV and (now) attestation resources which are not always deployed.

[9:31 AM] Larry Osterman
IMHO this should be in the nightly core CI pipeline and there should be a test-resources.json which deploys AKV, Storage*, and Attestation resources to enable the test to work.

[9:32 AM] George Arama
right, i was thinking of taking a peek at it to see what it's about, and what value it's adding. and also try to figure out why it decided to fail now. And remove it if it's useless, we already run other keyvault samples, and if it's duplicating samples ( which is what i suspect) then it might not add value

[9:33 AM] George Arama
also see what effort it would take to fix it if i decide it should stay

[9:34 AM] Larry Osterman
The reason it is now failing is that I added the factory for attestation. The attestation factory depends on making a service call to the attestation service.

[9:34 AM] Larry Osterman
And https://blobs.com/ is a pretty crappy attestation service instance.

[9:35 AM] Larry Osterman
IMHO it's not strictly useless. It is a decent integration test. However its location is really pretty broken (it's not a sample - it's a test, and we don't have any infrastructure for repo level tests).

[9:35 AM] George Arama
can we put an actual attestetion service ?

[9:35 AM] Larry Osterman
Sure - or we could use the attestation shared instance in some reason (WUS makes sense)
like 1

[9:35 AM] George Arama
aaa, ok , let me look into it and i'll circle back

[9:36 AM] Larry Osterman
For instance, you could use "https://sharedwus.wus.attest.azure.net" as the endpoint for the attestation service and the test will be happy as a clam until they turn off the lights.

[9:38 AM] George Arama
yeees this test was required by the powers that be, to make sure we can instantiate all clients together , it will be integrated in some uber pipeline that will run similar samples from all packages

[9:38 AM] George Arama
we got the sample ready a while back, but those guys were not fully ready with their pipeline ,

[9:39 AM] George Arama
i'll ping Daniel to see where they are