Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modules to manage network.ApplicationGateway resources as done with network.LoadBalancer #7234

Closed
boillodmanuel opened this issue Jan 29, 2020 · 4 comments

Comments

@boillodmanuel
Copy link

Feature Request

Hello,

network.ApplicationGateway provides only 1 module :

  • applicationgateways.go [MAIN]

network.LoadBalancer provides 7 modules :

  • loadbalancers.go [MAIN]
  • loadbalancerbackendaddresspools.go
  • loadbalancerfrontendipconfigurations.go
  • loadbalancerloadbalancingrules.go
  • loadbalancernetworkinterfaces.go
  • loadbalanceroutboundrules.go
  • loadbalancerprobes.go

The Azure cli for ApplicationGateway provides 20 modules, see here: https://docs.microsoft.com/en-us/cli/azure/network/application-gateway?view=azure-cli-latest

Could you add the missing modules in the SDK?

@ArcturusZhang
Copy link
Member

Hi @boillodmanuel thanks for this issue.
But unfortunately this feature request cannot be addressed.
The go SDK is auto-generated from the rest api specs by autorest, and it is designed to be a library corresponding to the rest-api. If the rest api does not support those methods you listed, the go SDK cannot contain them. In fact, the rest api allows you use the CreateOrUpdate method directly modify the loadbalancer instance to achieve those purpose.
In the meantime, azure-cli is carefully designed manually and written by humans.
Therefore I will close this issue, sorry about this.

@boillodmanuel
Copy link
Author

boillodmanuel commented Jan 30, 2020

I understand @ArcturusZhang, but in this case, this could be worth to move the issue to correct github repository or ask me to create the issue in the correct repo.
Otherwise, feedbacks will be lost...
And it could be great to mention it in README.md

@ArcturusZhang
Copy link
Member

I understand @ArcturusZhang, but in this case, this could be worth to move the issue to correct github repository or ask me to create the issue in the correct repo.
Otherwise, feedbacks will be lost...
And it could be great to mention it in README.md

Well, you could raise an issue ask for the api to create those resources independently in the azure-rest-api-specs repo. I could tag your issue there so the service team will have a look at that issue.

@boillodmanuel
Copy link
Author

Here is the azure-rest-api-specs issue: Azure/azure-rest-api-specs#8252

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants