Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ] Supports Spring Cloud Sleuth for Azure HTTP-based service client #24651

Closed
2 tasks done
moarychan opened this issue Oct 8, 2021 · 1 comment · Fixed by #24192
Closed
2 tasks done

[FEATURE REQ] Supports Spring Cloud Sleuth for Azure HTTP-based service client #24651

moarychan opened this issue Oct 8, 2021 · 1 comment · Fixed by #24192
Assignees
@moarychan
Labels
azure-spring All azure-spring related issues azure-spring-keyvault Spring keyvault related issues. azure-spring-storage Spring storage releated issues. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone
Spring Cloud Azur...

Comments

@moarychan
Copy link
Member

Is your feature request related to a problem? Please describe.
You can find the whole feature proposal here.

When the Spring Cloud Sleuth is enabled in an application, Sleuth will record the activities of Azure SDK services, which includes the HTTP-based service clients.

  • HTTP based client:
    • Key Vault secret client
    • Key Vault Cercates client
    • Storage Blob client
    • Storage Share client
    • Storage Queue client

Describe the solution you'd like
Two ways to achieve:
Use the HttpPipelinePolicy to start and end the span
Use com.azure.core.util.tracing.Tracer to enable the SDK HTTP-based service tracing.

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Description Added
  • Expected solution specified
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 8, 2021
@moarychan moarychan added azure-spring All azure-spring related issues azure-spring-keyvault Spring keyvault related issues. azure-spring-storage Spring storage releated issues. feature-request This issue requires a new behavior in the product in order be resolved. labels Oct 8, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 8, 2021
@moarychan moarychan linked a pull request Oct 8, 2021 that will close this issue
Support HTTP based Azure SDK service tracing by Spring Sleuth implementation #24192
Merged
@moarychan moarychan mentioned this issue Oct 8, 2021
Merged
@moarychan moarychan added this to the Backlog milestone Oct 8, 2021
@moarychan moarychan mentioned this issue Oct 8, 2021
Closed
@saragluna saragluna modified the milestones: Backlog, [2021] October Oct 9, 2021
@moarychan
Copy link
Member Author

This is a temporary solution for Sleuth users. We will mainly support the Open Telemetry library and the Tracer interface solution, we may not implement it temporarily.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@moarychan moarychan

Labels
azure-spring All azure-spring related issues azure-spring-keyvault Spring keyvault related issues. azure-spring-storage Spring storage releated issues. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Spring Cloud Azure
Archived in project
Milestone
Spring Cloud Azure 4.0 Beta
4 participants
@chenrujun @moarychan @saragluna @yiliuTo